From nobody Tue Nov 28 10:49:54 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SffNt5BhHz52TsN; Tue, 28 Nov 2023 10:50:06 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SffNt4gnmz4Wcj; Tue, 28 Nov 2023 10:50:06 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701168606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NhVE/Ag1P3tguN4JYUOyFZCJe7o3fdiRWdtnXYpK4CM=; b=CDBfN4YTffCbSLxuBDYc70Z/VdB12wD+d4MvVTyBBcwJxlWsuSTmZMQnk9Umw6MxBIX/0R oGfD4mRQ8V6pIQKj4nITZMk4gIDJjv5l2Nl8bLokVzS58N8O+ub2x0z9MY3jFbEjdqvbZb UE/M+O+E/BUxkJpgy0OIVrNKlzSOlGw3+aOO3GqX+wfnN6G7yl/WuqDTdtFhv+vMs8PyZJ i1zocznu2YPdPytc0tOeNdwsjqGDCJHi3w3a8he+ah63OZBc9MQCCDSRQC6410wshKoKen dq5zxFRhoOVVRqJ+9CoBIiDGNpe8zTlozqrROnYR4zz/orYgJaYTfH3bCCsKOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701168606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NhVE/Ag1P3tguN4JYUOyFZCJe7o3fdiRWdtnXYpK4CM=; b=x8Y5vAVMexs5gS1wkA7SwiMQD9dbp0CTdeBFl2HdA0fHEeRHBpYfzlg88AqbdDY8JmlXGE AXHjYNkOYl4GQUUSwNOmej0ImH3oyzy1nu5LHrA1kd16SnVKshdUdiYhbFoPafYvoBPp2y i5y6hrXWhAGQrnGHExAkBsygsjieo+OEYAmfiQ031BLBeK0HVdkWZNuMPzGmugneRJYkIR XOjGViWFlFU2uMkgxO5EokkqZsRBuEhY66a5d2w5a/o37/baS6H3Yb523UQVbGDrxHo6P2 ktGtl9t5YIEqidjAFAJbO372rA5thhBD/7s+ob/3LnK9RzdT1Stx22KOLq4lQQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701168606; a=rsa-sha256; cv=none; b=CcRhFVa0GPDyNrUgH7v7PC9NfnQ0JIcmMRtCjg+Xe22F9wgNI/To74yGgvqArR0sqqc92X +tOaEgKBU/h/hIF9iGKxuZzbMIfI0+MFzCRcqeF7vU1PtprF4NO7sylHqgEf9tvYRlLS8Q 7TzvmJNfUZRGNgEc5VymC/QwoWkDtp3mEUUByEc5ZhitUrLTtm5Hvbh2cPEoYbWwokt9qB vmVeO3WGp6jkjTA7C9Mo2KU42E/W+PrItrhRJ8puBKgSVpmoJcAGxzX4/KQKbhdlCl3goq JBxPVLcd7NrGQ6L97sStaHslwR3pCo00aIjI0hu96+eT2apeE27Xhr63gV1BKw== Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SffNt3YQjz1JM1; Tue, 28 Nov 2023 10:50:06 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-423c944352fso9503901cf.3; Tue, 28 Nov 2023 02:50:06 -0800 (PST) X-Gm-Message-State: AOJu0Yxq2+tI+FjGQwl1Q3HNAklfB3qbnD10v0l1fYIZz2QjayQ+AwaV mh2tJSryRN1VdbDOFg86i4Ai5O7rDzKymW7mrT0= X-Google-Smtp-Source: AGHT+IE7bU2NSu661SMCUSfuaxvBWZXr+L3NfNd2xBsovH43SllHwPizI9CaLP0LuMwxaWcNJusMgT6cPN587naOSZ4= X-Received: by 2002:a05:622a:401a:b0:423:98c3:a5f with SMTP id cf26-20020a05622a401a00b0042398c30a5fmr16396779qtb.29.1701168606145; Tue, 28 Nov 2023 02:50:06 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202311091932.3A9JWpBJ065961@gitrepo.freebsd.org> In-Reply-To: <202311091932.3A9JWpBJ065961@gitrepo.freebsd.org> From: Nuno Teixeira Date: Tue, 28 Nov 2023 10:49:54 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 9b214a66ea87 - main - x11-toolkits/wxgtk32: fix build with lld 17 To: Dimitry Andric Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000078f868060b342e76" --00000000000078f868060b342e76 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Dimitry, Will this commit be MFHed to quarterly? Thanks Dimitry Andric escreveu no dia quinta, 9/11/2023 =C3=A0(s= ) 19:50: > The branch main has been updated by dim: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3D9b214a66ea8788a6da299139decf5= 06a4b4f5ff1 > > commit 9b214a66ea8788a6da299139decf506a4b4f5ff1 > Author: Dimitry Andric > AuthorDate: 2023-11-09 19:26:44 +0000 > Commit: Dimitry Andric > CommitDate: 2023-11-09 19:32:02 +0000 > > x11-toolkits/wxgtk32: fix build with lld 17 > > Building x11-toolkits/wxgtk32 with lld 17 results in the following li= nk > errors: > > ld: error: version script assignment of 'WXU_3.2.1' to symbol > 'wxApp::GTKAllowDiagnosticsControl()' failed: symbol not defined > ld: error: version script assignment of 'WXU_3.2.1' to symbol > 'wxFileDialog::AddShortcut(const wxString&, int)' failed: symbol not defi= ned > > Add -Wl,--undefined-version to LDFLAGS to suppress these errors, sinc= e > wxWidgets reuses the same linker version script for all its shared > libraries. > > PR: 273753 > Approved by: blanket (desktop) > MFH: 2023Q4 > --- > x11-toolkits/wxgtk32/Makefile | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/x11-toolkits/wxgtk32/Makefile b/x11-toolkits/wxgtk32/Makefil= e > index 934fd79c649b..794704329f2a 100644 > --- a/x11-toolkits/wxgtk32/Makefile > +++ b/x11-toolkits/wxgtk32/Makefile > @@ -108,6 +108,11 @@ CONFIGURE_ARGS+=3D--disable-tls > CONFIGURE_ARGS+=3D--disable-precomp-headers > .endif > > +# wxWidgets uses the same linker version script for all its shared > libraries, so > +# some symbols are expectedly undefined. Suppress errors with lld >=3D 1= 7 > due to > +# these undefined symbols. > +LDFLAGS+=3D -Wl,--undefined-version > + > post-build-NLS-on: > @${DO_MAKE_BUILD} allmo -C ${BUILD_WRKSRC}/locale > > --=20 Nuno Teixeira FreeBSD Committer (ports) --00000000000078f868060b342e76 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Dimitry,

Will this com= mit be MFHed to quarterly?

Thanks
<= br>
Dimitry= Andric <dim@freebsd.org> escr= eveu no dia quinta, 9/11/2023 =C3=A0(s) 19:50:
The branch main has been updated by dim:
URL: https://cgi= t.FreeBSD.org/ports/commit/?id=3D9b214a66ea8788a6da299139decf506a4b4f5ff1

commit 9b214a66ea8788a6da299139decf506a4b4f5ff1
Author:=C2=A0 =C2=A0 =C2=A0Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2023-11-09 19:26:44 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2023-11-09 19:32:02 +0000

=C2=A0 =C2=A0 x11-toolkits/wxgtk32: fix build with lld 17

=C2=A0 =C2=A0 Building x11-toolkits/wxgtk32 with lld 17 results in the foll= owing link
=C2=A0 =C2=A0 errors:

=C2=A0 =C2=A0 =C2=A0 ld: error: version script assignment of 'WXU_3.2.1= ' to symbol 'wxApp::GTKAllowDiagnosticsControl()' failed: symbo= l not defined
=C2=A0 =C2=A0 =C2=A0 ld: error: version script assignment of 'WXU_3.2.1= ' to symbol 'wxFileDialog::AddShortcut(const wxString&, int)= 9; failed: symbol not defined

=C2=A0 =C2=A0 Add -Wl,--undefined-version to LDFLAGS to suppress these erro= rs, since
=C2=A0 =C2=A0 wxWidgets reuses the same linker version script for all its s= hared
=C2=A0 =C2=A0 libraries.

=C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0273753
=C2=A0 =C2=A0 Approved by:=C2=A0 =C2=A0 blanket (desktop)
=C2=A0 =C2=A0 MFH:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 2023Q4
---
=C2=A0x11-toolkits/wxgtk32/Makefile | 5 +++++
=C2=A01 file changed, 5 insertions(+)

diff --git a/x11-toolkits/wxgtk32/Makefile b/x11-toolkits/wxgtk32/Makefile<= br> index 934fd79c649b..794704329f2a 100644
--- a/x11-toolkits/wxgtk32/Makefile
+++ b/x11-toolkits/wxgtk32/Makefile
@@ -108,6 +108,11 @@ CONFIGURE_ARGS+=3D--disable-tls
=C2=A0CONFIGURE_ARGS+=3D--disable-precomp-headers
=C2=A0.endif

+# wxWidgets uses the same linker version script for all its shared librari= es, so
+# some symbols are expectedly undefined. Suppress errors with lld >=3D = 17 due to
+# these undefined symbols.
+LDFLAGS+=3D=C2=A0 =C2=A0 =C2=A0 -Wl,--undefined-version
+
=C2=A0post-build-NLS-on:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 @${DO_MAKE_BUILD} allmo -C ${BUILD_WRKSRC}/loca= le



--
Nuno Teixeira
FreeBSD Committ= er (ports)
--00000000000078f868060b342e76--