From owner-freebsd-ppc@FreeBSD.ORG  Thu Sep 22 03:44:27 2011
Return-Path: <owner-freebsd-ppc@FreeBSD.ORG>
Delivered-To: freebsd-ppc@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E1FF71065673
	for <freebsd-ppc@freebsd.org>; Thu, 22 Sep 2011 03:44:27 +0000 (UTC)
	(envelope-from grehan@freebsd.org)
Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12])
	by mx1.freebsd.org (Postfix) with ESMTP id A373A8FC13
	for <freebsd-ppc@freebsd.org>; Thu, 22 Sep 2011 03:44:27 +0000 (UTC)
Received: from dommail.onthenet.com.au (dommail.OntheNet.com.au [203.13.70.57])
	by alto.onthenet.com.au (Postfix) with ESMTPS id 658DA11AA8;
	Thu, 22 Sep 2011 13:25:21 +1000 (EST)
Received: from sshilpa2-lxp.hq.netapp.com (pos-ext.netapp.com [198.95.226.40])
	by dommail.onthenet.com.au (MOS 4.1.10-GA)
	with ESMTP id AYL86765 (AUTH peterg@ptree32.com.au);
	Thu, 22 Sep 2011 13:25:19 +1000
Message-ID: <4E7AAA9D.9010503@freebsd.org>
Date: Wed, 21 Sep 2011 21:25:17 -0600
From: Peter Grehan <grehan@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
	rv:1.9.2.22) Gecko/20110902 Thunderbird/3.1.14
MIME-Version: 1.0
To: Justin Hibbits <jrh29@alumni.cwru.edu>
References: <91CC14C1-14F2-41B3-81F1-D90B42F038CA@alumni.cwru.edu>
In-Reply-To: <91CC14C1-14F2-41B3-81F1-D90B42F038CA@alumni.cwru.edu>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: FreeBSD PowerPC ML <freebsd-ppc@freebsd.org>
Subject: Re: ofw syscons brightness patch
X-BeenThere: freebsd-ppc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the PowerPC <freebsd-ppc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ppc>,
	<mailto:freebsd-ppc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ppc>
List-Post: <mailto:freebsd-ppc@freebsd.org>
List-Help: <mailto:freebsd-ppc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ppc>,
	<mailto:freebsd-ppc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Sep 2011 03:44:28 -0000

Hi Justin,

> Attached is a patch that adds brightness control to ofw syscons
> (dev.sc.0.brightness sysctl). Pretty simple. Comments and tests
> requested. Hopefully the listserv doesn't eat the patch.

  Is it possible to have the value in the sysctl be 0-100, or 0-10 ? It 
might be a bit confusing for the user to have to know that the range is 
0x34-0xff, and have the sysctl code clamp to these.

  Are the MIN_BRIGHTNESS/MAX_BRIGHTNESS values the same for all models ?

later,

Peter.