From owner-freebsd-current@FreeBSD.ORG Fri Nov 4 14:16:42 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B5181106566B for ; Fri, 4 Nov 2011 14:16:42 +0000 (UTC) (envelope-from emaste@freebsd.org) Received: from mail1.sandvine.com (Mail1.sandvine.com [64.7.137.134]) by mx1.freebsd.org (Postfix) with ESMTP id 776BD8FC08 for ; Fri, 4 Nov 2011 14:16:42 +0000 (UTC) Received: from labgw2.phaedrus.sandvine.com (192.168.222.22) by WTL-EXCH-1.sandvine.com (192.168.196.31) with Microsoft SMTP Server id 14.0.694.0; Fri, 4 Nov 2011 10:05:53 -0400 Received: by labgw2.phaedrus.sandvine.com (Postfix, from userid 10332) id 8966433C02; Fri, 4 Nov 2011 10:05:53 -0400 (EDT) Date: Fri, 4 Nov 2011 10:05:53 -0400 From: Ed Maste To: Craig Rodrigues Message-ID: <20111104140553.GA39317@sandvine.com> References: <20111028204706.GA57454@sandvine.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Cc: freebsd-current@freebsd.org, Nima Misaghian Subject: Re: Adding disk firmware programming capability to camcontrol X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2011 14:16:42 -0000 On Thu, Nov 03, 2011 at 07:05:54PM -0700, Craig Rodrigues wrote: > On Fri, Oct 28, 2011 at 1:47 PM, Nima Misaghian wrote: > > Hi, > > > > I have got code developed by Andre Albsmeier that is capable of > > programming firmware of hard drives from several vendors and ?turned > > it into a camcontrol command. > ... > > I think the patch is fine in its current form. Very few "regular > users" need to reprogram hard drive firmware. > It is a special administrative operation. Thanks for reviewing. I discussed it with Ken Merry off-list and he mentioned the format command, which has a similar requirement. It has a -y flag to confirm the operation from the command line, and prompts for confirmation if the flag is not provided. Mirroring that behaviour sounds reasonable to me; we'll update the patch with that change before it gets committed. -Ed