From owner-cvs-all@FreeBSD.ORG Mon Aug 4 17:26:52 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BCD2D37B401; Mon, 4 Aug 2003 17:26:52 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6BE4943F75; Mon, 4 Aug 2003 17:26:52 -0700 (PDT) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h750Qq0U071356; Mon, 4 Aug 2003 17:26:52 -0700 (PDT) (envelope-from iedowse@repoman.freebsd.org) Received: (from iedowse@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h750QpZZ071355; Mon, 4 Aug 2003 17:26:51 -0700 (PDT) Message-Id: <200308050026.h750QpZZ071355@repoman.freebsd.org> From: Ian Dowse Date: Mon, 4 Aug 2003 17:26:51 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_syscalls.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2003 00:26:53 -0000 iedowse 2003/08/04 17:26:51 PDT FreeBSD src repository Modified files: sys/kern vfs_syscalls.c Log: In the mknod(), mkfifo(), link(), symlink() and undelete() syscalls, use vrele() instead of vput() on the parent directory vnode returned by namei() in the case where it is equal to the target vnode. This handles namei()'s somewhat strange (but documented) behaviour of not locking either vnode when the two vnodes are equal and LOCKPARENT but not LOCKLEAF is specified. Note that since a vnode double-unlock is not currently fatal, these coding errors were effectively harmless. Spotted by: Juergen Hannken-Illjes Reviewed by: mckusick Revision Changes Path 1.329 +23 -5 src/sys/kern/vfs_syscalls.c