From owner-svn-src-head@FreeBSD.ORG Wed Feb 15 15:48:49 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8D4FC106564A; Wed, 15 Feb 2012 15:48:49 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail03.syd.optusnet.com.au (mail03.syd.optusnet.com.au [211.29.132.184]) by mx1.freebsd.org (Postfix) with ESMTP id 0AD538FC0C; Wed, 15 Feb 2012 15:48:48 +0000 (UTC) Received: from c211-30-171-136.carlnfd1.nsw.optusnet.com.au (c211-30-171-136.carlnfd1.nsw.optusnet.com.au [211.30.171.136]) by mail03.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id q1FFmkwI029033 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 16 Feb 2012 02:48:47 +1100 Date: Thu, 16 Feb 2012 02:48:46 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Gleb Smirnoff In-Reply-To: <20120215152729.GQ20404@FreeBSD.org> Message-ID: <20120216023627.D3142@besplex.bde.org> References: <201202151426.q1FEQpn7065868@svn.freebsd.org> <20120216015919.X2940@besplex.bde.org> <20120215152729.GQ20404@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Bruce Evans Subject: Re: svn commit: r231760 - head/sys/netgraph X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2012 15:48:49 -0000 On Wed, 15 Feb 2012, Gleb Smirnoff wrote: > On Thu, Feb 16, 2012 at 02:19:37AM +1100, Bruce Evans wrote: > B> systm was already sorted. Like param.h, it defines important macros that > ... > is this patch okay? Yes. > I'd prefer to leave sys/queue.h included explicitly. Yes, there is nothing better. sys/queue.h is now referenced 926 times in .depend for a kernel with 951 object files. This is more references than even for sys/param.h (901). This shows that sys/queue.h might as well be standard pollution. But hopefully, lots of the dependencies on queue.h are not real ones, but are the result of other pollution which might be cleanable. Bruce