Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 Jan 2003 19:53:44 +0200
From:      Peter Pentchev <roam@ringlet.net>
To:        Yar Tikhiy <yar@FreeBSD.org>
Cc:        Ceri Davies <setantae@submonkey.net>, Julian Mayer <julianmayer@mac.com>, knu@FreeBSD.org, ports@FreeBSD.org, hackers@FreeBSD.org
Subject:   Re: FreeBSD Port: portupgrade-20021216
Message-ID:  <20030123175344.GC19717@straylight.oblivion.bg>
In-Reply-To: <20030123174706.GA8943@comp.chem.msu.su>
References:  <F123A396-2E66-11D7-9D30-00039303B9CC@mac.com> <20030123081224.GA471@straylight.oblivion.bg> <20030123101216.GA2856@submonkey.net> <20030123134749.GA377@straylight.oblivion.bg> <20030123174706.GA8943@comp.chem.msu.su>

next in thread | previous in thread | raw e-mail | index | archive | help

--K8nIJk4ghYZn606h
Content-Type: text/plain; charset=windows-1251
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 23, 2003 at 08:47:06PM +0300, Yar Tikhiy wrote:
> On Thu, Jan 23, 2003 at 03:47:49PM +0200, Peter Pentchev wrote:
> >=20
> > Attached is a patch to the libexec/ftpd source, which adds a new -P
> > option taking an argument of either a numeric port number or a service
> > name as described in the getaddrinfo(3) manual page.  What do people
> > think about adding this functionality?
>=20
> Peter, here is a bit reworked version of your patch.
> Does it look reasonable?

Yes, this looks fine; the data connection port issue was brought up by
Matthew Seaman in a private message to me, which I did not respond to
immediately, because I wanted to feel the general thoughts on the
subject.  Now that you have incorporated it into your patch, it all
sounds great :)

I see that you have also changed my '.Nm' macro for the 'ftp' service to
'.Dq'; that's fine too, I was in quite a bit of doubt myself over
exactly which mdoc macro to use.  The '.Nm' came from the telnet(1)
manual page, but it did not look quite right to me.

Thanks for your fast reaction :)  I guess libexec/ftpd is your code, so
it's your call to commit at will if nobody objects.

G'luck,
Peter

--=20
Peter Pentchev	roam@ringlet.net	roam@FreeBSD.org
PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
"yields falsehood, when appended to its quotation." yields falsehood, when =
appended to its quotation.

--K8nIJk4ghYZn606h
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD8DBQE+MCwo7Ri2jRYZRVMRAg5bAJ9/LZIyfPy8auzMhWQ59m0riZ/wBQCgixWT
AAPf9PIEJgyggJp000OWgq4=
=gbNo
-----END PGP SIGNATURE-----

--K8nIJk4ghYZn606h--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030123175344.GC19717>