From owner-freebsd-smp Sun Jan 13 16:13: 8 2002 Delivered-To: freebsd-smp@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 864AA37B416; Sun, 13 Jan 2002 16:13:03 -0800 (PST) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id LAA18754; Mon, 14 Jan 2002 11:12:57 +1100 Date: Mon, 14 Jan 2002 11:13:47 +1100 (EST) From: Bruce Evans X-X-Sender: To: Alfred Perlstein Cc: John Baldwin , , , Subject: Re: fd locking. In-Reply-To: <20020113052807.R7984@elvis.mu.org> Message-ID: <20020114110256.Q3471-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-smp@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Sun, 13 Jan 2002, Alfred Perlstein wrote: > * Alfred Perlstein [020113 04:10] wrote: > > * Alfred Perlstein [020112 19:17] wrote: > > > * John Baldwin [020112 19:00] wrote: > > > > > > Bruce is going to not like you for adding nested includes of sys/lock.h and > > > > sys/mutex.h. Instead, add nested includes of sys/_lock.h and sys/_mutex.h, and > > > > then add sys/lock.h and sys/mutex.h to the files that need them. > > > > > > Can this be delayed? No. > > > > I'll start on this. > > Ugh, what a pain! > > Basically I wind up with an annoying problem. I want fhold and fhold_locked > to be inlines. However they use mutexes, _however_, they aren't used for > the most part, __however__ a lot of people include these files... This shows that they shouldn't be inlines, at least in the bloated case where the mutex functions are used. Don't add includes of all over to "fix" this. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message