From owner-cvs-src@FreeBSD.ORG Wed Jul 30 14:39:31 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 294FC37B401; Wed, 30 Jul 2003 14:39:31 -0700 (PDT) Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id A915043FA3; Wed, 30 Jul 2003 14:39:29 -0700 (PDT) (envelope-from jroberson@chesapeake.net) Received: from localhost (jroberson@localhost) by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id h6ULdTq85947; Wed, 30 Jul 2003 17:39:29 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Wed, 30 Jul 2003 17:39:29 -0400 (EDT) From: Jeff Roberson To: Bosko Milekic In-Reply-To: <200307301855.h6UItFgg063471@repoman.freebsd.org> Message-ID: <20030730173717.X14210-100000@mail.chesapeake.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jul 2003 21:39:31 -0000 On Wed, 30 Jul 2003, Bosko Milekic wrote: > > While I'm here, also silence GCC warnings by turning uma_slab_alloc() > from inline to real function. It's too big to be an inline. > > Reviewed by: JeffR Thanks bosko. When I originally wrote this I fell into the 'functions are so expensive!' trap. I must not have been thinking clearly. The slow path in UMA is hit so infrequently that perf improvements in it are not noticable. Cheers, Jeff