From owner-freebsd-current@FreeBSD.ORG  Fri Apr 14 16:24:12 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E3C4516A404;
	Fri, 14 Apr 2006 16:24:12 +0000 (UTC) (envelope-from sos@FreeBSD.org)
Received: from spider.deepcore.dk
	(cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk
	[80.166.201.166])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 429F443D48;
	Fri, 14 Apr 2006 16:24:12 +0000 (GMT) (envelope-from sos@FreeBSD.org)
Received: from sos.deepcore.dk (sos.deepcore.dk [194.192.25.130])
	by spider.deepcore.dk (8.13.6/8.13.4) with ESMTP id k3EGOCHD011848;
	Fri, 14 Apr 2006 18:24:12 +0200 (CEST)
	(envelope-from sos@FreeBSD.org)
From: =?ISO-8859-1?Q?S=F8ren?= Schmidt <sos@FreeBSD.org>
To: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
In-Reply-To: <20060415.012059.130244002.iwasaki@jp.FreeBSD.org>
References: <20060414.180622.30189283.iwasaki@jp.FreeBSD.org>
	<20060414.233013.41626908.iwasaki@jp.FreeBSD.org>
	<1145029263.912.4.camel@sos.deepcore.dk>
	<20060415.012059.130244002.iwasaki@jp.FreeBSD.org>
Content-Type: text/plain; charset=iso8859-1
Organization: FreeBSD project
Date: Fri, 14 Apr 2006 18:24:10 +0200
Message-Id: <1145031850.912.6.camel@sos.deepcore.dk>
Mime-Version: 1.0
X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 8bit
X-mail-scanned: by DeepCore Virus & Spam killer v1.16
Cc: acpi@FreeBSD.org, current@FreeBSD.org
Subject: Re: CFR: ACPI Dock driver
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: sos@FreeBSD.org
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Apr 2006 16:24:13 -0000

On Lør, 2006-04-15 at 01:20 +0900, Mitsuru IWASAKI wrote:
> Hi,
> 
> > --- ata-all.c   31 Mar 2006 08:09:04 -0000      1.271
> > +++ ata-all.c   14 Apr 2006 15:39:20 -0000
> > @@ -277,8 +277,8 @@
> >      if (!dev || !(ch = device_get_softc(dev)))
> >         return ENXIO;
> > 
> > -    /* wait for the channel to be IDLE before entering suspend mode */
> > -    while (1) {
> > +    /* wait for the channel to be IDLE or detached before suspending */
> > +    while (ch->r_irq) {
> >         mtx_lock(&ch->state_mtx);
> >         if (ch->state == ATA_IDLE) {
> >             ch->state = ATA_ACTIVE;
> > 
> > That I'll gladly commit for you instead...
> 
> Yes, This have also the same effect.  I prefer this.

Good, this one also doesn't relay on a mutx that has been destroyed :)

I'll commit asap...

-Søren