From owner-svn-src-head@freebsd.org Mon Feb 26 23:20:38 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 99D60F2C1FF; Mon, 26 Feb 2018 23:20:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4410972424; Mon, 26 Feb 2018 23:20:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 93DEF10A8BA; Mon, 26 Feb 2018 18:20:37 -0500 (EST) From: John Baldwin To: Alan Somers Cc: Warner Losh , Steve Wills , Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328612 - head/lib/libc/stdlib Date: Mon, 26 Feb 2018 11:03:43 -0800 Message-ID: <1882799.O9cP9dHevK@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: References: <201801310305.w0V35EU4090569@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 26 Feb 2018 18:20:37 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2018 23:20:38 -0000 On Sunday, February 25, 2018 07:52:49 AM Alan Somers wrote: > I'm seeing the same error during the build of usr.sbin/nologin for > riscv.riscv64sf. Has anybody figured out a solution yet? It's kind of messy. I have a WIP patch series here: https://github.com/freebsd/freebsd/compare/master...bsdjhb:softfloat_symbol_map I'm trying to determine if we should just be ditching more of the soft-float stuff from libc in favor of compiler-rt instead. I think with my current tree I still have a (different) breakage on riscv64sf. > On Thu, Feb 1, 2018 at 9:09 PM, Warner Losh wrote: > > > > > > > On Thu, Feb 1, 2018 at 8:34 PM, Steve Wills wrote: > > > >> This, somehow, seems to have broken the mips64 build: > >> > >> https://ci.freebsd.org/job/FreeBSD-head-mips64-build/216/consoleFull > >> > >> The previous rev works. > >> > > > > This breaks devd, of all things, with > > > > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In > > function `__gedf2': > > /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:96: multiple > > definition of `__gedf2' > > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(gedf2.o):/ > > usr/src/lib/libc/softfloat/gedf2.c:18: first defined here > > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In > > function `__eqdf2': > > /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:126: multiple > > definition of `__eqdf2' > > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(eqdf2.o):/ > > usr/src/lib/libc/softfloat/eqdf2.c:18: first defined here > > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In > > function `__ltdf2': > > /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:131: multiple > > definition of `__ltdf2' > > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(ltdf2.o):/ > > usr/src/lib/libc/softfloat/ltdf2.c:18: first defined here > > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In > > function `__nedf2': > > /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:136: multiple > > definition of `__nedf2' > > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(nedf2.o):/ > > usr/src/lib/libc/softfloat/nedf2.c:18: first defined here > > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In > > function `__gtdf2': > > /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:141: multiple > > definition of `__gtdf2' > > /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(gtdf2.o):/ > > usr/src/lib/libc/softfloat/gtdf2.c:18: first defined here > > > > undefined.... devd doesn't even use strtodl. > > > > (looks like the code to associate make output with the right commands is > > broken, since I had to dig for it. > > > > Warner > > > > > >> Steve > >> > >> > >> On 01/30/2018 22:05, Warner Losh wrote: > >> > >>> Author: imp > >>> Date: Wed Jan 31 03:05:14 2018 > >>> New Revision: 328612 > >>> URL: https://svnweb.freebsd.org/changeset/base/328612 > >>> > >>> Log: > >>> Move strtold wrapper from strtol.c to its own strtold.c. This code > >>> was written by theraven@ (David Chisnall) entirely, there's no > >>> original Berkeley code left here so just copy his copyright over. > >>> > >>> > > -- John Baldwin