From owner-freebsd-net@FreeBSD.ORG  Mon Feb 27 20:03:09 2006
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4FE6E16A420
	for <freebsd-net@freebsd.org>; Mon, 27 Feb 2006 20:03:09 +0000 (GMT)
	(envelope-from craig@olyun.gank.org)
Received: from ion.gank.org (ion.gank.org [64.81.113.130])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C57F243D48
	for <freebsd-net@freebsd.org>; Mon, 27 Feb 2006 20:03:06 +0000 (GMT)
	(envelope-from craig@olyun.gank.org)
Received: by ion.gank.org (mail, from userid 1001)
	id E1C317CD; Mon, 27 Feb 2006 14:03:02 -0600 (CST)
Date: Mon, 27 Feb 2006 14:03:01 -0600
From: Craig Boston <craig@olyun.gank.org>
To: "JINMEI Tatuya / ?$B?@L@C#:H" <jinmei@isl.rdc.toshiba.co.jp>
Message-ID: <20060227200301.GB247@nowhere>
References: <20060125152032.GA40581@nowhere> <20060127020528.GA18728@nowhere>
	<y7v4q2u1dsi.wl%jinmei@isl.rdc.toshiba.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <y7v4q2u1dsi.wl%jinmei@isl.rdc.toshiba.co.jp>
User-Agent: Mutt/1.4.2.1i
Cc: freebsd-net@freebsd.org
Subject: Re: Race condition in ip6_getpmtu (actually gif)?
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Feb 2006 20:03:09 -0000

On Mon, Feb 20, 2006 at 08:15:57PM +0900, JINMEI Tatuya wrote:
> > Attached is a quick hack to protect the cached route with a mutex.  A
> > better fix with less overhead would be to allocate the route in a local
> > variable on the stack, and only copy it to the softc if route caching is
> > enabled.  I'll run for a couple weeks with the patch and file a PR if
> > that fixes it.
> 
> I guess this problem was fixed with the following changes:
> 
> http://www.jp.freebsd.org/cgi/cvsweb.cgi/src/sys/net/if_gif.c.diff?r1=1.57&r2=1.58
> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet6/in6_gif.c.diff?r1=1.23&r2=1.24

Yes, it was.  I saw the changes in those files when I attempted to
re-merge my patch after a cvsup.  I've currently been running with no
panics for 12 days with rev 1.52.2.4 of if_gif.c and rev 1.22.2.2 of
in6_gif.c.

Craig