Date: Sat, 4 Aug 2018 10:42:36 -0700 From: Eitan Adler <lists@eitanadler.com> To: Chris Rees <crees@bayofrum.net> Cc: eugen@grosbein.net, Matthias Fechner <idefix@fechner.net>, freebsd ports <freebsd-ports@freebsd.org>, Rene Ladan <rene@freebsd.org> Subject: Re: Delete a port Message-ID: <CAF6rxgnN_DcRerExsaBhvU7LQuSDa1nDha7Li4mPL5FoCO%2BnNQ@mail.gmail.com> In-Reply-To: <30EF106C-0794-4A24-918E-FE3132F8A632@bayofrum.net> References: <a48a6cd2-e088-618a-61e6-909f71ce8ba5@fechner.net> <20180804140317.GA22029@blogreen.org> <5B65B4FB.70103@grosbein.net> <30EF106C-0794-4A24-918E-FE3132F8A632@bayofrum.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 4 Aug 2018 at 08:13, Chris Rees <crees@bayofrum.net> wrote:
>
> Hey,
>
> On 4 August 2018 15:15:23 BST, Eugene Grosbein <eugen@grosbein.net> wrote=
:
> >04.08.2018 21:03, Romain Tarti=C3=A8re wrote:
> >
> >> On Sat, Aug 04, 2018 at 12:28:41PM +0200, Matthias Fechner wrote:
> >>> ./rmport: svnlog: not found
> >>>
> >>> Anyone an idea what is wrong?
> >>
> >> Never used this script, but I guess you are hitting line 390:
> >>
> >> | $EDITOR svnlog
> >>
> >> Any chance $EDITOR is not set?
> >
> >It seems, rmport script needs a patch:
> >
> >Index: Tools/scripts/rmport
> >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >--- Tools/scripts/rmport (revision 476322)
> >+++ Tools/scripts/rmport (working copy)
> >@@ -39,6 +39,7 @@
> > # MAINTAINER=3D crees@FreeBSD.org
> > #
> >
> >+EDITOR=3D${EDITOR:-vi}
> > PORTSDIR=3D${PORTSDIR:-/usr/ports}
> > INDEX=3D${PORTSDIR}/`make -C ${PORTSDIR} -V INDEXFILE`
>
> Thanks both.
>
> Feel free to commit, but please use the absolute path to vi?
Why? Would't one want to respect the user's preference when it comes
to an editor? This preference is implicit when it comes to PATH.
--=20
Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnN_DcRerExsaBhvU7LQuSDa1nDha7Li4mPL5FoCO%2BnNQ>