From owner-svn-src-head@FreeBSD.ORG Thu Jun 24 02:57:07 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A6730106566B; Thu, 24 Jun 2010 02:57:07 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 178BE8FC13; Thu, 24 Jun 2010 02:57:06 +0000 (UTC) Received: by vws13 with SMTP id 13so1642542vws.13 for ; Wed, 23 Jun 2010 19:57:06 -0700 (PDT) Received: by 10.220.127.3 with SMTP id e3mr4604732vcs.126.1277348226199; Wed, 23 Jun 2010 19:57:06 -0700 (PDT) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.220.191.67 with HTTP; Wed, 23 Jun 2010 19:56:46 -0700 (PDT) In-Reply-To: <20100623.202647.867924114552092597.imp@bsdimp.com> References: <201006232326.o5NNQEtK011793@svn.freebsd.org> <3659E546-80A0-4E82-8112-40B093728D81@mac.com> <20100623.202647.867924114552092597.imp@bsdimp.com> From: Juli Mallett Date: Wed, 23 Jun 2010 19:56:46 -0700 X-Google-Sender-Auth: wHfKWWNsCce2Z7VrO5rNrAfoM4E Message-ID: To: "M. Warner Losh" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, xcllnt@mac.com, src-committers@freebsd.org, nwhitehorn@freebsd.org Subject: Re: svn commit: r209490 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jun 2010 02:57:07 -0000 On Wed, Jun 23, 2010 at 19:26, M. Warner Losh wrote: > : > # =A0 =A0define HZ 1000 > : > # =A0else > : > # =A0 =A0define HZ 100 > > Shouldn't this be defined in some file in ARCH/include instead? Didn't it used to be? I think the problem with doing that is that then someone inevitably writes code that uses HZ instead of the (tunable) hz. Of course, you can hide it behind an obscure #ifdef and even give it an intimidating name.