From owner-freebsd-current@freebsd.org Mon Mar 21 00:56:05 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E702AD6DC4 for ; Mon, 21 Mar 2016 00:56:05 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 35F8693C for ; Mon, 21 Mar 2016 00:56:04 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 8da571a8-eeff-11e5-b278-7d22021d92d7 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.34.117.227 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.34.117.227]) by outbound1.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Mon, 21 Mar 2016 00:55:06 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.14.9) with ESMTP id u2L0stNu007335; Sun, 20 Mar 2016 18:54:56 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1458521695.68920.86.camel@freebsd.org> Subject: Re: sdhci_pci.ko fails to load From: Ian Lepore To: Jilles Tjoelker Cc: Guido Falsi , cem@FreeBSD.org, freebsd-current Date: Sun, 20 Mar 2016 18:54:55 -0600 In-Reply-To: <20160320224034.GB78464@stack.nl> References: <56EF12C1.1020202@madpilot.net> <56EF143F.9030308@madpilot.net> <56EF1744.4030607@madpilot.net> <1458511534.68920.84.camel@freebsd.org> <20160320224034.GB78464@stack.nl> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 00:56:05 -0000 On Sun, 2016-03-20 at 23:40 +0100, Jilles Tjoelker wrote: > On Sun, Mar 20, 2016 at 04:05:34PM -0600, Ian Lepore wrote: > > On Sun, 2016-03-20 at 22:33 +0100, Guido Falsi wrote: > > > On 03/20/16 22:21, Guido Falsi wrote: > > > > On 03/20/16 22:18, Conrad Meyer wrote: > > > > > Try 'kldload mmc' first. 'sdhci_pci' is missing a > > > > > MODULE_DEPEND > > > > > on mmc. > > > > > As I said, when loading sdhci_pci I had already loaded module > > > > mmc. > > > > > Anyway I'll try that again just to make sure, maybe I missed it > > > > and > > > > thought I had it loaded. > > > > > I'll followup shortly. > > > > I confirm that I had already loaded mmc.ko. > > > [snip] > > > the full error in dmesg is the same as stated before: > > > > link_elf_obj: symbol mmc_driver undefined > > > linker_load_file: Unsupported file type > > > > Meybe the symbol is optimized out by the compiler in the module? > > > I suspect this is caused by my r292180 back in December. I'm > > trying to > > figure out if that's the case and if so, how to fix it. > > I think this is caused by the missing MODULE_DEPEND. The kernel > linker > only looks for symbols in the ELF objects containing the module > itself > and its declared dependencies. > > If mmc is compiled into the main kernel image, this is always > satisfied. > Thanks for the clue about the linker, it would have taken me forever to figure that out by flailing around like I was doing. Hopefully this is all fixed now with r297127, but I was only able to test it on arm systems (I have no x86 with sdhci). -- Ian