From owner-p4-projects@FreeBSD.ORG Thu Sep 8 16:35:13 2005 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id CC20316A421; Thu, 8 Sep 2005 16:35:12 +0000 (GMT) X-Original-To: perforce@FreeBSD.org Delivered-To: perforce@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8FB2716A41F; Thu, 8 Sep 2005 16:35:12 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id F3FC343D45; Thu, 8 Sep 2005 16:35:11 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.3/8.13.3) with ESMTP id j88GZAAk037906; Thu, 8 Sep 2005 10:35:10 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4320683F.1060001@samsco.org> Date: Thu, 08 Sep 2005 10:35:11 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050615 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Nate Lawson References: <200509080737.j887bmMo009640@repoman.freebsd.org> <43206729.9020001@root.org> In-Reply-To: <43206729.9020001@root.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org Cc: Perforce Change Reviews , Scott Long Subject: Re: PERFORCE change 83251 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2005 16:35:13 -0000 Nate Lawson wrote: > Scott Long wrote: > >> http://perforce.freebsd.org/chv.cgi?CH=83251 >> >> Change 83251 by scottl@scottl-junior on 2005/09/08 07:37:47 >> >> Import Danny Braniss' iSCSI initiator stack. >> >> Affected files ... >> >> .. //depot/projects/iscsi/blurb#1 add >> .. //depot/projects/iscsi/src/sys/dev/iscsi/isc_cam.c#1 add >> .. //depot/projects/iscsi/src/sys/dev/iscsi/isc_sm.c#1 add >> .. //depot/projects/iscsi/src/sys/dev/iscsi/isc_soc.c#1 add >> .. //depot/projects/iscsi/src/sys/dev/iscsi/isc_subr.c#1 add >> .. //depot/projects/iscsi/src/sys/dev/iscsi/iscsi.c#1 add >> .. //depot/projects/iscsi/src/sys/dev/iscsi/iscsi.h#1 add >> .. //depot/projects/iscsi/src/sys/dev/iscsi/iscsi_subr.c#1 add >> .. //depot/projects/iscsi/src/sys/dev/iscsi/iscsivar.h#1 add >> .. //depot/projects/iscsi/src/sys/modules/iscsi_initiator/Makefile#1 add >> .. //depot/projects/iscsi/src/usr.sbin/iscontrol/Makefile#1 add >> .. //depot/projects/iscsi/src/usr.sbin/iscontrol/auth.c#1 add >> .. //depot/projects/iscsi/src/usr.sbin/iscontrol/config.c#1 add >> .. //depot/projects/iscsi/src/usr.sbin/iscontrol/config.sample#1 add >> .. //depot/projects/iscsi/src/usr.sbin/iscontrol/fsm.c#1 add >> .. //depot/projects/iscsi/src/usr.sbin/iscontrol/iscontrol.c#1 add >> .. //depot/projects/iscsi/src/usr.sbin/iscontrol/iscontrol.h#1 add >> .. //depot/projects/iscsi/src/usr.sbin/iscontrol/pdu.c#1 add >> .. //depot/projects/iscsi/src/usr.sbin/iscontrol/pdu.h#1 add >> .. //depot/projects/iscsi/src/usr.sbin/iscontrol/textkey.h#1 add >> .. //depot/projects/scottl-camlock/src/sys/cam/cam_xpt.c#17 edit >> >> Differences ... >> >> ==== //depot/projects/scottl-camlock/src/sys/cam/cam_xpt.c#17 >> (text+ko) ==== >> >> @@ -1527,7 +1527,7 @@ >> s = splsoftcam(); >> camq_resize(&device->drvq, device->drvq.array_size - 1); >> >> - device->generation++; >> + atomic_add_int(&device->generation, 1); >> >> SLIST_REMOVE(periph_head, periph, cam_periph, periph_links); >> > > > And a locking change. :) > > Nice about iSCSI. Will having iscontrol in usr.sbin prevent mounting > /usr as an iSCSI partition? How hard is it to do iSCSI root mounts? > The current incarnation of this code requires iscontrol to do discovery and initial connection. Without it, you don't even get a /dev device. So it's really only suitable for secondary storge. At some point we'll probably look at putting discovery into the kernel. Scott