From owner-freebsd-current Fri Sep 22 9: 0:35 2000 Delivered-To: freebsd-current@freebsd.org Received: from gidora.zeta.org.au (gidora.zeta.org.au [203.26.10.25]) by hub.freebsd.org (Postfix) with SMTP id 0825837B43F for ; Fri, 22 Sep 2000 09:00:21 -0700 (PDT) Received: (qmail 16136 invoked from network); 22 Sep 2000 16:00:16 -0000 Received: from unknown (HELO bde.zeta.org.au) (203.2.228.102) by gidora.zeta.org.au with SMTP; 22 Sep 2000 16:00:16 -0000 Date: Sat, 23 Sep 2000 03:00:11 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Adrian Chadd Cc: freebsd-fs@FreeBSD.ORG, freebsd-current@FreeBSD.ORG Subject: Re: Fsck wrappers, revisited In-Reply-To: <20001223112038.A37548@roaming.cacheboy.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 23 Dec 2000, Adrian Chadd wrote: > Here's the patch: > > --- fsck.c.orig Sat Dec 23 11:13:30 2000 > +++ fsck.c Sat Dec 23 11:13:34 2000 > @@ -501,7 +501,7 @@ > errx(1, "partition `%s' is not of a legal vfstype", > str); > - if ((vfstype = dktypenames[t]) == NULL) > + if ((vfstype = fstypenames[t]) == NULL) > errx(1, "vfstype `%s' on partition `%s' is not supported", > fstypenames[t], str); > > > So now is a problem which I'm sure the NetBSD people came up against. > The fstypenames are names like 4.2BSD, vinum, ISO9660, etc. NetBSD fixed > this by creating a new list 'mountnames[]', which maps the fs type to > a string. fs typenames are already strings in FreeBSD (the kernel's vfc_index is an implementation detail which should not be visible in applications). > http://cvsweb.netbsd.org/bsdweb.cgi/syssrc/sys/sys/disklabel.h.diff?r1=1.60&r2=1.61 > > What do people think about doing this as well? It would certainly make things > a little tidier, but every time a new fs comes in the magic autodetection code > will need to be updated (if appropriate, of course.) This would be a bug. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message