From owner-cvs-all  Tue Feb  5  8:37:58 2002
Delivered-To: cvs-all@freebsd.org
Received: from rina.r.dl.itc.u-tokyo.ac.jp (rina.r.dl.itc.u-tokyo.ac.jp [133.11.199.247])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8CCA437B404; Tue,  5 Feb 2002 08:37:52 -0800 (PST)
Received: from sohgo.carrots.uucp.r.dl.itc.u-tokyo.ac.jp (sohgo.carrots.uucp.r.dl.itc.u-tokyo.ac.jp [IPv6:3ffe:b80:5b0:3:200:e8ff:fe14:9f8a])
	by rina.r.dl.itc.u-tokyo.ac.jp (8.12.2/3.7W-rina.r-Nankai-Koya) with ESMTP id g15GbIT5050365 ;
	Wed, 6 Feb 2002 01:37:20 +0900 (JST)
Received: from sohgo.carrots.uucp.r.dl.itc.u-tokyo.ac.jp (localhost [IPv6:::1])
	by sohgo.carrots.uucp.r.dl.itc.u-tokyo.ac.jp (8.12.2/3.7W-carrots-Tokyu-Meguro) with ESMTP id g15GbBhE018727 ;
	Wed, 6 Feb 2002 01:37:12 +0900 (JST)
Received: (from root@localhost)
	by sohgo.carrots.uucp.r.dl.itc.u-tokyo.ac.jp (8.12.2/3.7W-submit-carrots-Tokyu-Meguro) with UUCP id g15GasWa018692 ;
	Wed, 6 Feb 2002 01:36:54 +0900 (JST)
Received: from bunko.carrots.uucp.r.dl.itc.u-tokyo.ac.jp (localhost [127.0.0.1])
	by bunko.carrots.uucp.r.dl.itc.u-tokyo.ac.jp (8.12.2/3.7W-nkth.carrots-Saitama-Misono) with ESMTP id g15EZPAu035551 ;
	Tue, 5 Feb 2002 23:35:26 +0900 (JST)
Message-Id: <200202051435.g15EZPAu035551@bunko.carrots.uucp.r.dl.itc.u-tokyo.ac.jp>
Date: Tue, 05 Feb 2002 23:35:25 +0900
From: Seigo Tanimura <tanimura@r.dl.itc.u-tokyo.ac.jp>
To: John Baldwin <jhb@FreeBSD.org>
Cc: Seigo Tanimura <tanimura@r.dl.itc.u-tokyo.ac.jp>,
	cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_sx.c
In-Reply-To: <XFMail.020204234229.jhb@FreeBSD.org>
References: <200201180921.g0I9LFn30513@freefall.freebsd.org>
	<XFMail.020204234229.jhb@FreeBSD.org>
User-Agent: Wanderlust/2.8.1 (Something) SEMI/1.14.3 (Ushinoya) FLIM/1.14.3
 (=?ISO-8859-1?Q?Unebigory=F2mae?=) APEL/10.3 MULE XEmacs/21.1 (patch 14)
 (Cuyahoga Valley) (i386--freebsd)
Organization: Digital Library Research Division, Information Techinology Centre, The University of Tokyo
MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya")
Content-Type: text/plain; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, 04 Feb 2002 23:42:29 -0500 (EST),
  John Baldwin <jhb@FreeBSD.org> said:

>> tanimura    2002/01/18 01:21:15 PST
>> 
>> Modified files:
>> sys/kern             kern_sx.c 
>> Log:
>> Invert the test of sx_xholder for SX_LOCKED. We need to warn if a
>> thread other than the curthread holds an sx.
>> 
>> While I am here, break a line at the end of warning.

jhb> Good catch, the default case also needs the newline.

panic() breaks a line on its own, so we do not need the newline.

-- 
Seigo Tanimura <tanimura@r.dl.itc.u-tokyo.ac.jp> <tanimura@FreeBSD.org>

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message