From owner-freebsd-hackers Wed Oct 15 15:53:51 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id PAA15909 for hackers-outgoing; Wed, 15 Oct 1997 15:53:51 -0700 (PDT) (envelope-from owner-freebsd-hackers) Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id PAA15898 for ; Wed, 15 Oct 1997 15:53:40 -0700 (PDT) (envelope-from brian@awfulhak.org) Received: from gate.lan.awfulhak.org (localhost [127.0.0.1]) by awfulhak.demon.co.uk (8.8.5/8.8.5) with ESMTP id XAA18393; Wed, 15 Oct 1997 23:23:16 +0100 (BST) Message-Id: <199710152223.XAA18393@awfulhak.demon.co.uk> X-Mailer: exmh version 2.0zeta 7/24/97 To: Julian Elischer cc: Darren Reed , hackers@FreeBSD.ORG Subject: Re: Freebsd 3.0 current fails ipfilter 3.2b8 build (fwd) In-reply-to: Your message of "Wed, 15 Oct 1997 08:56:18 PDT." <3444E7A2.41C67EA6@whistle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 15 Oct 1997 23:23:16 +0100 From: Brian Somers Sender: owner-freebsd-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > All the "_var.h" files contain variables who'se scope is within the > kernel only. The only exception is LKMs which should define KERNEL. > I don't know who did this, (I see in the logs it was garrett) > but the idea is simply to make it more obvios when you are > doing the WRONG thing > and including kernel private variables (that are subject to change, > and not part of the API) . > > julian But "struct ifnet" is decl'd in if_var.h and referenced from many other files. It's therefore necessary to #include if_var.h before including the likes of if_ether.h or in_var.h. > Darren Reed wrote: > > > > Before I commit a change that will fix this absurdity to FreeBSD (i.e. > > include if_var.h from if.h), perhaps someone can explain why this > > (seemingly needless) change was made. I'd certainly welcome the ``fix'', but I suspect you'll have some opposition. -- Brian , , Don't _EVER_ lose your sense of humour....