From owner-freebsd-bugs@FreeBSD.ORG  Thu Sep 30 16:00:55 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1536E16A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 30 Sep 2004 16:00:55 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0783843D48
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 30 Sep 2004 16:00:55 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8UG0skI076918
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 30 Sep 2004 16:00:54 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8UG0sdL076917;
	Thu, 30 Sep 2004 16:00:54 GMT
	(envelope-from gnats)
Date: Thu, 30 Sep 2004 16:00:54 GMT
Message-Id: <200409301600.i8UG0sdL076917@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Barry Pederson <bp@barryp.org>
Subject: Re: bin/56914: ftpd ignores default umask settings
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Barry Pederson <bp@barryp.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Sep 2004 16:00:55 -0000

The following reply was made to PR bin/56914; it has been noted by GNATS.

From: Barry Pederson <bp@barryp.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: bin/56914: ftpd ignores default umask settings
Date: Thu, 30 Sep 2004 11:00:35 -0500

 I've been burned by this too, but here's a pretty simple patch that stops the 
 login class umasks from overriding what's on the commandline:
 
 
 
 --- libexec/ftpd/ftpd.c.original        Fri Feb 14 06:42:42 2003
 +++ libexec/ftpd/ftpd.c Thu Sep 30 10:48:22 2004
 @@ -1187,7 +1187,7 @@
          pw = NULL;
   #ifdef LOGIN_CAP
          setusercontext(NULL, getpwuid(0), (uid_t)0,
 -                      LOGIN_SETPRIORITY|LOGIN_SETRESOURCES|LOGIN_SETUMASK);
 +                      LOGIN_SETPRIORITY|LOGIN_SETRESOURCES);
   #endif
          logged_in = 0;
          guest = 0;
 @@ -1428,7 +1428,7 @@
          }
          setusercontext(lc, pw, (uid_t)0,
                  LOGIN_SETLOGIN|LOGIN_SETGROUP|LOGIN_SETPRIORITY|
 -               LOGIN_SETRESOURCES|LOGIN_SETUMASK);
 +               LOGIN_SETRESOURCES);
   #else
          setlogin(pw->pw_name);
          (void) initgroups(pw->pw_name, pw->pw_gid);