From owner-svn-src-head@freebsd.org Mon Jun 4 15:25:38 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D52AAFED1AC; Mon, 4 Jun 2018 15:25:37 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 51F496D1B0; Mon, 4 Jun 2018 15:25:37 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: by mail-wm0-x243.google.com with SMTP id m129-v6so14689428wmb.3; Mon, 04 Jun 2018 08:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=SxrKi6BNWbZbUApzfIfgQKjT83lU+Oy7GlJlpB7NZno=; b=UloU/hT1LvjsuVjEYKAyTff0QLTS3uOJOZO3HuinwqmC0l5xSjfE1OeJOt9fz5uFhP 6pMD9CZHEi5Ug9fa7l6HYiqcKq788ECdnK0rV3K5Evh3toI/SoG8qnPYoUl2fmeQlqL2 GGoUZsrI5Rxtd0iez/vLn3qLTgG+HFMN0+EsrRK0OamlV/Yh7cGO2+59QC4sUqjTzP6K jGtD1jMiVmGr82HFcN/mzT3qUcR716Jcz4bbSQTkdrd8WbupbGVErmFY46s6JkdaDnp2 F7uANAaHfpdWBlah+2VbtJ0SgQ25hKtJX+bq7vWbeJnuT2IQhE0T+ijgNkWGGh6EMnW1 pYEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SxrKi6BNWbZbUApzfIfgQKjT83lU+Oy7GlJlpB7NZno=; b=g3YhidAnuDFpHZJ/0SZShi05kYRTGpLdxx6AShMaQnuBycqletLSE/rRfSqlW7ZLGI dHyvB8MBDSvskdrPpOD/EBotrY93CqughjQqayyol2/hcNh8PXDDgGx90kdUw2jYRU1D VSqQSMa0yohhVE+WPyUkHY7BTv9x7w0CVWZsceET4u40pmEu7bcVVvZ2+L6i6Cai35hv hDvTVQPei6xuL5BUIRvzvaeqXV/8rMoKc9aTb3v8gmhnLsivJgeYdoRlvFE5X4wcejZY qEZNbU4bZCzG205VBODoRp0QsHOqNF54XTmXaii3OC7wJnJK85kE02y5saYx472selCE MyrA== X-Gm-Message-State: APt69E04KbVIbTfzowNLXcPXMOMQ/vgWKQTUXRbgRcixXhrHp6eaclEt jV7ZRR5xPxf1Zfd6z9yZbg8cdf2TWFt8DITw6D0FTQ== X-Google-Smtp-Source: ADUXVKJbs/khn1Lk+bVd8qbcKQDvWMf+wZnDXqaucbUjPAs6cODjxQk7r8Od0JrJ5GNxY5XtW7ccB08YTx2WhNyq7LM= X-Received: by 2002:a1c:6241:: with SMTP id w62-v6mr9289493wmb.115.1528125935979; Mon, 04 Jun 2018 08:25:35 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:b35c:0:0:0:0:0 with HTTP; Mon, 4 Jun 2018 08:25:35 -0700 (PDT) In-Reply-To: <201806041518.w54FIYRZ096337@pdx.rh.CN85.dnsmgr.net> References: <201806040630.w546UaRJ005645@repo.freebsd.org> <201806041518.w54FIYRZ096337@pdx.rh.CN85.dnsmgr.net> From: Matt Joras Date: Mon, 4 Jun 2018 08:25:35 -0700 Message-ID: Subject: Re: svn commit: r334609 - head/usr.sbin/pmc To: rgrimes@freebsd.org Cc: Matt Macy , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2018 15:25:38 -0000 On Mon, Jun 4, 2018 at 8:18 AM, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> Author: mmacy >> Date: Mon Jun 4 06:30:35 2018 >> New Revision: 334609 >> URL: https://svnweb.freebsd.org/changeset/base/334609 >> >> Log: >> pmc filter: avoid spurious gcc uninitialized warning > > Is it truely uninitialzized, or are you silencing a bogus warning, > this commit and the code does not make that clear, and that should > be made clear. I didn't check the code, but given he said "spurious", I don't think there's much ambiguity. Matt > > Thanks, > Rod >> >> Modified: >> head/usr.sbin/pmc/cmd_pmc_filter.c >> >> Modified: head/usr.sbin/pmc/cmd_pmc_filter.c >> ============================================================================== >> --- head/usr.sbin/pmc/cmd_pmc_filter.c Mon Jun 4 05:55:40 2018 (r334608) >> +++ head/usr.sbin/pmc/cmd_pmc_filter.c Mon Jun 4 06:30:35 2018 (r334609) >> @@ -145,7 +145,7 @@ pmc_filter_handler(uint32_t *lwplist, int lwpcount, ui >> if ((ps = pmclog_open(infd)) == NULL) >> errx(EX_OSERR, "ERROR: Cannot allocate pmclog parse state: %s\n", strerror(errno)); >> >> - pmccount = 0; >> + eventcount = pmccount = 0; >> while (pmclog_read(ps, &ev) == 0) { >> if (ev.pl_type == PMCLOG_TYPE_INITIALIZE) >> memcpy(cpuid, ev.pl_u.pl_i.pl_cpuid, PMC_CPUID_LEN); >> >> > > -- > Rod Grimes rgrimes@freebsd.org >