From owner-freebsd-current Thu Mar 22 13:42: 1 2001 Delivered-To: freebsd-current@freebsd.org Received: from srv1.cosmo-project.de (srv1.cosmo-project.de [213.83.6.106]) by hub.freebsd.org (Postfix) with ESMTP id 997E837B722 for ; Thu, 22 Mar 2001 13:41:54 -0800 (PST) (envelope-from ticso@mail.cicely.de) Received: from mail.cicely.de (cicely20 [10.1.1.22]) by srv1.cosmo-project.de (8.11.0/8.11.0) with ESMTP id f2MLfnX48189; Thu, 22 Mar 2001 22:41:49 +0100 (CET) Received: (from ticso@localhost) by mail.cicely.de (8.11.0/8.11.0) id f2MLgUQ01661; Thu, 22 Mar 2001 22:42:30 +0100 (CET) Date: Thu, 22 Mar 2001 22:42:29 +0100 From: Bernd Walter To: Alfred Perlstein Cc: "Niels Chr. Bank-Pedersen" , freebsd-current@FreeBSD.ORG Subject: Re: devfs+vinum trouble Message-ID: <20010322224229.C1130@cicely20.cicely.de> References: <20010322184639.A253@cicely20.cicely.de> <20010322213929.F1082@bank-pedersen.dk> <20010322124503.E9431@fw.wintelcom.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="lrZ03NoBR/3+SXJZ" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010322124503.E9431@fw.wintelcom.net>; from bright@wintelcom.net on Thu, Mar 22, 2001 at 12:45:03PM -0800 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --lrZ03NoBR/3+SXJZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 22, 2001 at 12:45:03PM -0800, Alfred Perlstein wrote: > * Niels Chr. Bank-Pedersen [010322 12:39] wrote: > > On Thu, Mar 22, 2001 at 06:46:40PM +0100, Bernd Walter wrote: > > > 1. The minor numbers are completely different from what I have > > > without devfs. > > > Without a volume is 91,0 91,1 ... > > > With I get 91,0 91,0x1000000 91,20000000 ... > > > Similar plexes, ... > > > 2. When I mount I get with all volume nodes the same filesystem. > > > Not astonishing with the broken minors. > > > 3. I have 6 volumes and only 5 devnodes in vol showed up. > > > All 6 are shown with vinum list. > > > 4. during vinum init I get errors: > > > WARNING: Driver mistake: repeat make_dev("vinum/controld") > > > WARNING: Driver mistake: repeat make_dev("vinum/Control") > > > WARNING: Driver mistake: repeat make_dev("vinum/control") > > > It doesn't matter if I have devfs compiled in or not. > > > And I get similars during kldunload. > > > > > > It's on an i386 based system with source from 21th March. > > > > > > Same here. > > > > > T USERS MORE INFO PLZ K THNX. > 1. You mixed type and instance number - see the diff 2. A result of 1. 3. I asume the same reason as 1. and 2. The number was filtered and the call failed. Yet to check. 4. I don't have anything more than this. But they seem to be harmless. -- B.Walter COSMO-Project http://www.cosmo-project.de ticso@cicely.de Usergroup info@cosmo-project.de --lrZ03NoBR/3+SXJZ Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=delme Index: vinumconfig.c =================================================================== RCS file: /vol/freebsd-cvs/src/sys/dev/vinum/vinumconfig.c,v retrieving revision 1.40 diff -u -r1.40 vinumconfig.c --- vinumconfig.c 2001/02/20 12:14:01 1.40 +++ vinumconfig.c 2001/03/22 21:35:45 @@ -1223,7 +1223,7 @@ if (sd->sectors < 0) throw_rude_remark(EINVAL, "sd %s has no length spec", sd->name); - sd->dev = make_dev(&vinum_cdevsw, VINUMRMINOR(VINUM_SD_TYPE, sdno), + sd->dev = make_dev(&vinum_cdevsw, VINUMRMINOR(sdno, VINUM_SD_TYPE), UID_ROOT, GID_WHEEL, S_IRUSR|S_IWUSR, "vinum/sd/%s", sd->name); if (state != sd_unallocated) /* we had a specific state to set */ sd->state = state; /* do it now */ @@ -1382,7 +1382,7 @@ if (plex->organization == plex_disorg) throw_rude_remark(EINVAL, "No plex organization specified"); - plex->dev = make_dev(&vinum_cdevsw, VINUMRMINOR(VINUM_PLEX_TYPE, plexno), + plex->dev = make_dev(&vinum_cdevsw, VINUMRMINOR(plexno, VINUM_PLEX_TYPE), UID_ROOT, GID_WHEEL, S_IRUSR|S_IWUSR, "vinum/plex/%s", plex->name); if ((plex->volno < 0) /* we don't have a volume */ @@ -1544,7 +1544,7 @@ vol->size = max(vol->size, PLEX[vol->plex[i]].length); vinum_conf.volumes_used++; /* one more in use */ - vol->dev = make_dev(&vinum_cdevsw, VINUMRMINOR(VINUM_VOLUME_TYPE, volno), + vol->dev = make_dev(&vinum_cdevsw, VINUMRMINOR(volno, VINUM_VOLUME_TYPE), UID_ROOT, GID_WHEEL, S_IRUSR|S_IWUSR, "vinum/vol/%s", vol->name); } --lrZ03NoBR/3+SXJZ-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message