From owner-dev-commits-src-main@freebsd.org Wed Apr 7 22:07:33 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E5B695C665B for ; Wed, 7 Apr 2021 22:07:33 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FFz5x5v59z4sG1 for ; Wed, 7 Apr 2021 22:07:32 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qv1-xf2a.google.com with SMTP id 30so9868939qva.9 for ; Wed, 07 Apr 2021 15:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AcxALaPkBV283ibBsoWpKilY3QZX81ihDp3ac51ByRU=; b=CoFce29xRMiCAtcfv5vBGxTqu5plYMrPAF0yaybYlF1vxwbFToCQR21xhsevfAnYHw DDFac79ovsjyxBL8LDLcR5/7n4mm4p3GjMw5eFwV6kmi49gmOv2GwYHH1sG0Pgy9e9d6 gEnFGR8PYLbIMIhm7D+QJJoCcuWPK0sfY8i1PS+KsvY1AzmI9ObQisLMEGN15KEmJwaD vLpwSTs+QjXo7vQ5jZ2wFY/vH7PX2SrhcDZA7lHaz5R8JwtrhsZM6x2UMKmFmbZ5y4yy l8E6eO7CwWe9sHuLEGtlwSZVaGVf1KtSg+bPb/zEfjnhgDGUrrwyRNh2f0YKJ+ckKVGV nvKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AcxALaPkBV283ibBsoWpKilY3QZX81ihDp3ac51ByRU=; b=LCHwer0dyeWGkRVmnr8vH3MZ84zh6yrnn4EXiawxQl6go2DOUyjWSnoEPGwMzV3qJx w6LSZuSi3WP/kIKrZElkjINOnogxGcgDW1VBHOv2oaTMj7NFxcmxTo0S6XH8IodmVbar hzWelxc2QxtvYUtBfZtJ8p32c9jylxFdHrc+n/Uml4KLaiwATd1kB52CqLDH2gl86S39 +E1QiLsKl35Ppq34botiljhTFOUPvUgYFQywLWjOcGuKDdXaPmk2732DOWeFwCHLn344 KUxX8RrsG0j993BQLj3KSkfpfVWTy8kHG8Z56wziC1SNuKfYa/8hN+yvPLJR0DkZU29k DIQg== X-Gm-Message-State: AOAM532T3lnPBnJFB9qUPhNi7K2Tb0ym1Ki5FDxa9Vzfd5eFx44PkjPg NipLXLBjFbNSZohDLwglDiWCjw== X-Google-Smtp-Source: ABdhPJy2IF0UuzS+BI8UP/UKUoK0qbnyUAw4deq3M+i/mZU7PemZ6IgrzBWnKAYGLOQ+NvSbsDvpOQ== X-Received: by 2002:a0c:eb05:: with SMTP id j5mr5352590qvp.32.1617833251918; Wed, 07 Apr 2021 15:07:31 -0700 (PDT) Received: from mutt-hbsd (pool-100-16-222-53.bltmmd.fios.verizon.net. [100.16.222.53]) by smtp.gmail.com with ESMTPSA id e7sm17557334qth.27.2021.04.07.15.07.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 15:07:31 -0700 (PDT) Date: Wed, 7 Apr 2021 18:07:30 -0400 From: Shawn Webb To: Vincenzo Maffione Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 15dc713ceb57 - main - netmap: vtnet: add support for netmap offsets Message-ID: <20210407220730.6z6j2ejytu3j67ik@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202104072142.137LgrJC015011@gitrepo.freebsd.org> <20210407214622.gsedn2cuuj7mblq2@mutt-hbsd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="esmlgnma4wdtnhxg" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4FFz5x5v59z4sG1 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Apr 2021 22:07:34 -0000 --esmlgnma4wdtnhxg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable No, just the one line: (void)addr; On Wed, Apr 07, 2021 at 11:58:45PM +0200, Vincenzo Maffione wrote: > Hi, > Do you mean the whole commit? This adds vtnet support for "offsets" in > the netmap buffers. Main use case is that applications can easily zerocopy > push and pop protocol headers from packets. >=20 > Cheers, > Vincenzo >=20 > On Wed, Apr 7, 2021, 11:46 PM Shawn Webb wro= te: >=20 > > Hey Vincenzo, > > > > On Wed, Apr 07, 2021 at 09:42:53PM +0000, Vincenzo Maffione wrote: > > > The branch main has been updated by vmaffione: > > > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=3D15dc713ceb57d0d61c1dc54b1d550= da42d250730 > > > > > > commit 15dc713ceb57d0d61c1dc54b1d550da42d250730 > > > Author: Vincenzo Maffione > > > AuthorDate: 2021-04-07 21:32:20 +0000 > > > Commit: Vincenzo Maffione > > > CommitDate: 2021-04-07 21:32:20 +0000 > > > > > > netmap: vtnet: add support for netmap offsets > > > > > > Follow-up change to a6d768d845c173823785c71bb18b40074e7a8998. > > > This change adds support for netmap offsets. > > > --- > > > sys/dev/netmap/if_vtnet_netmap.h | 16 ++++++++++------ > > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > > > diff --git a/sys/dev/netmap/if_vtnet_netmap.h > > b/sys/dev/netmap/if_vtnet_netmap.h > > > index a05781255218..a423e71331be 100644 > > > --- a/sys/dev/netmap/if_vtnet_netmap.h > > > +++ b/sys/dev/netmap/if_vtnet_netmap.h > > > @@ -84,12 +84,14 @@ vtnet_netmap_txsync(struct netmap_kring *kring, i= nt > > flags) > > > for (; nm_i !=3D head; nm_i =3D nm_next(nm_i, lim)) { > > > /* we use an empty header here */ > > > struct netmap_slot *slot =3D &ring->slot[nm_i]; > > > + uint64_t offset =3D nm_get_offset(kring, slot); > > > u_int len =3D slot->len; > > > uint64_t paddr; > > > void *addr =3D PNMB(na, slot, &paddr); > > > int err; > > > > > > - NM_CHECK_ADDR_LEN(na, addr, len); > > > + (void)addr; > > > > What is this change for? > > > > Thanks, > > > > -- > > Shawn Webb > > Cofounder / Security Engineer > > HardenedBSD > > > > > > https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb= /03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc > > --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --esmlgnma4wdtnhxg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmBuLSIACgkQ/y5nonf4 4fo3Mg//bSObVg3MZ1sG6AziQOMrCrexwj0wLgni1DTsrlhJ5ZUNi72Kd8cnptaF h78O0Qi6ryDyV2rDWneFDBvdQrmkZlV3BfDCIeKFaRj1PqQkezYfAZgcaXOdZQuH 0r+wtiHQEf3mCqENfzcp8B4aKgb95JH1xBMZ23irpz1hFF8DpqvmOeqoXPfbU+ca ME/e9uHNwhO7q8+Px36/N3Dc4g3SEimSIwkDRLuNlw+T9sTcJ71l4OtgJz9PfNsm j99gnCi35R/hodDrFkWKN1h/biTzM6lahuVPK5cltFkUoyVGPWlOEAIncptrwLJ0 nPlWN3dZmDqQqnde15YWxYDO1tqT81x8GMAGHFebiAOx1VtYCCYzQ5vEZblaQ0vj Im+ObsuyGM7XwRuUjJtcLhzTCwlbwqPgZWQ766jlOv+2h7dv52sxqB60gmku6YwX vzhXdtytx+pweLg7SfbeRyYMCkYNNdnnXV/JBV6l3nSF8cZW9mb9+BeECoa/V4mA NOdszRTbiQgs2sfmI62gXc461Q0e0lU5nVYtufMNoHVbPOgzTo4XBnlsek8pxyaA 8V0ZE44wO8rGLgZh5QhkZg42RscpacAWRlpnUP9hjyjBq8a32zEYRJddFuMOi6DF lBg/JeDPB+xXZxUHINEO+mjTc0Sa3alpMjGhFuGlhTYBXHOgNpI= =YhmQ -----END PGP SIGNATURE----- --esmlgnma4wdtnhxg--