From owner-p4-projects@FreeBSD.ORG  Thu Jan 28 11:50:40 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 185D01065676; Thu, 28 Jan 2010 11:50:40 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D1222106566C
	for <perforce@freebsd.org>; Thu, 28 Jan 2010 11:50:39 +0000 (UTC)
	(envelope-from raj@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id BD3618FC08
	for <perforce@freebsd.org>; Thu, 28 Jan 2010 11:50:39 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o0SBodun035110
	for <perforce@freebsd.org>; Thu, 28 Jan 2010 11:50:39 GMT
	(envelope-from raj@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o0SBodEO035108
	for perforce@freebsd.org; Thu, 28 Jan 2010 11:50:39 GMT
	(envelope-from raj@freebsd.org)
Date: Thu, 28 Jan 2010 11:50:39 GMT
Message-Id: <201001281150.o0SBodEO035108@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	raj@freebsd.org using -f
From: Rafal Jaworowski <raj@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 173823 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jan 2010 11:50:40 -0000

http://p4web.freebsd.org/chv.cgi?CH=173823

Change 173823 by raj@raj_fdt on 2010/01/28 11:50:30

	Simplify handling #address-cells and #size-cells in LBC attachment.

Affected files ...

.. //depot/projects/fdt/sys/powerpc/mpc85xx/lbc.c#4 edit

Differences ...

==== //depot/projects/fdt/sys/powerpc/mpc85xx/lbc.c#4 (text+ko) ====

@@ -320,14 +320,8 @@
 	int tuple_size, tuples;
 	int i, rv, bank;
 
-	addr_cells = fdt_parent_addr_cells(node);
-	if (addr_cells > 0) {
-		rv = OF_searchprop(OF_parent(node), "#size-cells",
-		    &size_cells, sizeof(size_cells));
-		if (rv <= 0)
-			size_cells = 1;
-	} else
-		size_cells = 0;
+	if (fdt_addrsize_cells(OF_parent(node), &addr_cells, &size_cells) != 0)
+		return (ENXIO);
 
 	tuple_size = sizeof(pcell_t) * (addr_cells + size_cells);
 	tuples = OF_getprop_alloc(node, "reg", tuple_size, (void **)&reg);