From owner-freebsd-current@FreeBSD.ORG Sun Jun 30 21:30:07 2013 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 0718FFC1; Sun, 30 Jun 2013 21:30:07 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wg0-x231.google.com (mail-wg0-x231.google.com [IPv6:2a00:1450:400c:c00::231]) by mx1.freebsd.org (Postfix) with ESMTP id 6E3A01CB1; Sun, 30 Jun 2013 21:30:06 +0000 (UTC) Received: by mail-wg0-f49.google.com with SMTP id a12so3119424wgh.28 for ; Sun, 30 Jun 2013 14:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=4L/0jv1H9LrfrxbsZfYAD9S3jUrc5bn0++E/VZQQCMo=; b=Mz28V8+4EbS09Z8laa6feTvpqMTEnYa6A+kaFv3X2Dd6YClQjQTDTc2tRmrBJS22JZ 2i35Ds1YbOBgjhHTf1MJHQG6BmKV5ASlCzt+Vw6vfnNqSGU0FqOHerNru8NyomdyecUh Bq2q2fQOOdFJWijfsLCHYtXgMkZc4v23t2IDsqEnhev49ZkT7VjoPtD+kWC5CZKq+Ivw r9P39hYJ1t7HjAcotZIIvYhdCOdH0pmoB5qE7TCoDDyoKoSrEK6IGo+BdGQPCPijGRzw zHXMV2xdc53qe5OTKzKsJPyKBrpylQnDyLxPMgkbWOQ+hizX6YwHxeY5dWQNp4RIZxjg gHJQ== X-Received: by 10.194.48.49 with SMTP id i17mr18449506wjn.55.1372627805476; Sun, 30 Jun 2013 14:30:05 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPSA id dv12sm10419681wic.3.2013.06.30.14.30.03 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 30 Jun 2013 14:30:04 -0700 (PDT) Date: Sun, 30 Jun 2013 23:29:59 +0200 From: Mateusz Guzik To: Mikolaj Golub Subject: Re: panic: Lock filedesc structure not share locked Message-ID: <20130630212959.GC22492@dft-labs.eu> References: <20130630094150.00004a9c@unknown> <20130630082756.GA22492@dft-labs.eu> <20130630212334.GC3714@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20130630212334.GC3714@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Alexander Leidinger , current@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jun 2013 21:30:07 -0000 On Mon, Jul 01, 2013 at 12:23:35AM +0300, Mikolaj Golub wrote: > On Sun, Jun 30, 2013 at 10:27:57AM +0200, Mateusz Guzik wrote: > > On Sun, Jun 30, 2013 at 09:41:50AM +0200, Alexander Leidinger wrote: > > > Hi, > > > > > > with head as of r252381 on amd64, I got the following panic after > > > starting tmux and creating a 2nd terminal window inside tmux > > > (ctrl- + c): > > > ---snip--- > > > panic: Lock filedesc structure not share locked @ /space/system/usr_src/sys/kern/kern_descrip.c:3448 > > > > > > cpuid = 2 > > > KDB: stack backtrace: > > > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xffffff839ee566d0 > > > kdb_backtrace() at kdb_backtrace+0x39/frame 0xffffff839ee56780 > > > vpanic() at vpanic+0x126/frame 0xffffff839ee567c0 > > > panic() at panic+0x43/frame 0xffffff839ee56820 > > > _sx_assert() at _sx_assert+0x134/frame 0xffffff839ee56830 > > > _sx_sunlock() at _sx_sunlock+0x46/frame 0xffffff839ee56860 > > > kern_proc_filedesc_out() at kern_proc_filedesc_out+0x420/frame 0xffffff839ee568e0 > > > sysctl_kern_proc_filedesc() at sysctl_kern_proc_filedesc+0x66/frame 0xffffff839ee56950 > > > sysctl_root() at sysctl_root+0x1bd/frame 0xffffff839ee569a0 > > > userland_sysctl() at userland_sysctl+0x192/frame 0xffffff839ee56a40 > > > sys___sysctl() at sys___sysctl+0x74/frame 0xffffff839ee56af0 > > > amd64_syscall() at amd64_syscall+0x23c/frame 0xffffff839ee56bf0 > > > Xfast_syscall() at Xfast_syscall+0xfb/frame 0xffffff839ee56bf0 > > > ---snip--- > > > > > > > Can you try this (only compile-tested): > > diff --git a/sys/kern/kern_descrip.c b/sys/kern/kern_descrip.c > > index e760fe5..7aa17cd 100644 > > --- a/sys/kern/kern_descrip.c > > +++ b/sys/kern/kern_descrip.c > > @@ -3272,6 +3272,8 @@ export_fd_to_sb(void *data, int type, int fd, int fflags, int refcnt, > > if (efbuf->remainder < kif->kf_structsize) { > > /* Terminate export. */ > > efbuf->remainder = 0; > > + if (!locked && efbuf->fdp != NULL) > > + FILEDESC_SLOCK(efbuf->fdp); > > return (0); > > } > > efbuf->remainder -= kif->kf_structsize; > > > > Mateusz, thank you for spotting this lock leakage. Regardless if this > is the root cause of the reported panic (it looks like it is), this > fix should be definetly committed. Will you do this? > I think it will be better if you do this and then MFC all commits. -- Mateusz Guzik