Date: Mon, 5 Feb 2018 22:25:55 +0100 From: "O. Hartmann" <ohartmann@walstatt.org> To: Jason Harmening <jason.harmening@gmail.com> Cc: "O. Hartmann" <ohartmann@walstatt.org>, David Wolfskill <david@catwhisker.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328489 - head/sys/conf Message-ID: <20180205222622.43f5d3e7@thor.intern.walstatt.dynvpn.de> In-Reply-To: <e6a89b40-8ce3-d688-d9ec-c918718a0509@gmail.com> References: <201801272013.w0RKDaMU098200@repo.freebsd.org> <20180127214755.3c59661e@thor.intern.walstatt.dynvpn.de> <98501f75-1a1b-9221-c52d-24415230a886@gmail.com> <20180129130022.GT1125@albert.catwhisker.org> <20180204133337.3d03f01d@thor.intern.walstatt.dynvpn.de> <e6a89b40-8ce3-d688-d9ec-c918718a0509@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/VM=+vVrQKfdJb0xnMWBnlly
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Am Sun, 4 Feb 2018 10:22:31 -0800
Jason Harmening <jason.harmening@gmail.com> schrieb:
> On 02/04/18 04:33, O. Hartmann wrote:
> > Am Mon, 29 Jan 2018 05:00:22 -0800
> > David Wolfskill <david@catwhisker.org> schrieb:
> > =20
> >> On Mon, Jan 29, 2018 at 02:10:04AM -0800, Jason Harmening wrote: =20
> >>>>
> >>>> This happens now if PORTS_MODULE=3Dx11/nvidia-driver is defined in /=
etc/src.conf:
> >>>>
> >>>> [...]
> >>>> --- kernel-install ---
> >>>> mkdir -p /boot/kernel
> >>>> install -p -m 555 -o root -g wheel kernel /boot/kernel/
> >>>> --- ports-install ---
> >>>> Variable OBJTOP is recursive.
> >>>>
> >>>> make[8]: stopped =20
> >>> ...
> >>>
> >>> David sent me logs of the failing case; thanks David! =20
> >>
> >> Happy to help! :-)
> >> =20
> >>> The failure happens when buildkernel and installkernel are run
> >>> separately instead of all-up, e.g. 'make kernel'. The installkernel
> >>> step is leaving MK_AUTO_OBJ=3Dno in the env passed to the port build.=
It
> >>> looks like at least one of the install stages of nvidia-driver needs =
to
> >>> generate temporary output, which leads to confusion when the port isn=
't
> >>> built as though it's an in-tree component.
> >>>
> >>> Can you guys try out the attached patch? =20
> >>
> >> I tried it both on my build machine (which does not use kernel modules
> >> from ports, and thus did not exhibit the problem -- but I thought that
> >> verifying that the patch did not break that case worth checking) and on
> >> my laptop (which did exhibit the problem).
> >>
> >> It worked in both cases with no issues for me.
> >>
> >> Thanks! :-)
> >>
> >> Peace,
> >> david =20
> >=20
> > The problem still persists!
> >=20
> > I'm on CURRENT, FreeBSD 12.0-CURRENT #32: Sun Feb 4 09:41:39 CET 2018 =
amd64, the
> > source tree is at revision 328839.
> >=20
> >=20
> > I use WITH_META_MODE=3DYES in /etc/src.conf. My /etc/make.conf consists=
of a .include
> > statement which reels in /usr/local/etc/ports.conf in which I define ev=
erything
> > outside the source tree for ports (in case of the nvidia driver, its DI=
STVERSION).
> > This worked before and should work again. Today I checked out a complet=
ely
> > fresh /usr/src and gleanced the /usr/obj folder and rebuilt the system =
- and get the
> > error again:
> >=20
> > [...] =20
> > =3D=3D=3D> Ports module x11/nvidia-driver (install) =20
> > cd ${PORTSDIR:-/usr/ports}/x11/nvidia-driver; env -u CC -u CXX -u CP=
P -u
> > MAKESYSPATH MAKEFLAGS=3D"-j 4 -J 15,16 .MAKE.LEVEL.ENV=3DMAKELEVEL KERN=
EL=3Dkernel
> > MK_AUTO_OBJ=3Dno =20
> ^^^^^
> Looks like you haven't applied the patch? MK_AUTO_OBJ being left set in=
=20
> MAKEFLAGS by installkernel was part of the problem.
>=20
> That said, the fix I have up for review is slightly different:
> https://reviews.freebsd.org/D14143
>=20
> > TARGET=3Damd64 TARGET_ARCH=3Damd64" SYSDIR=3D/usr/src/sys
> > PATH=3D/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/sbin:/usr/obj/usr/sr=
c/amd64.amd64/tmp/legacy/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/bi=
n:/usr/obj/usr/src/amd64.amd64/tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tm=
p/usr/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin:/usr/local/sbin
> > SRC_BASE=3D/usr/src OSVERSION=3D1200056
> > WRKDIRPREFIX=3D/usr/obj/usr/src/amd64.amd64/sys/THOR make -B deinstall =
reinstall =3D=3D=3D>
> > Deinstalling for nvidia-driver =3D=3D=3D> Deinstalling nvidia-driver-=
387.34 Updating
> > database digests format: . done Checking integrity... done (0 conflicti=
ng)
> > Deinstallation has been requested for the following 1 packages (of 0 pa=
ckages in the
> > universe):
> >=20
> > Installed packages to be REMOVED:
> > nvidia-driver-387.34
> >=20
> > Number of packages to be removed: 1
> >=20
> > The operation will free 99 MiB.
> > [1/1] Deinstalling nvidia-driver-387.34...
> > [1/1] Deleting files for nvidia-driver-387.34: .......... done =20
> > =3D=3D=3D> Staging for nvidia-driver-387.34
> > =3D=3D=3D> nvidia-driver-387.34 depends on file: /usr/local/lib/libGL=
.so - found
> > =3D=3D=3D> nvidia-driver-387.34 depends on file: /usr/local/libdata/p=
kgconfig/x11.pc -
> > found =3D=3D=3D> nvidia-driver-387.34 depends on
> > file: /usr/local/libdata/pkgconfig/xorg-server.pc =20
> > - found =3D=3D=3D> nvidia-driver-387.34 depends on
> > file: /usr/local/libdata/pkgconfig/xext.pc
> > - found =3D=3D=3D> Generating temporary packing list =20
> > =3D=3D=3D> src (install)
> > =3D=3D=3D> src/nvidia (install) =20
> > Variable OBJTOP is recursive.
> >=20
> > make[8]: stopped
> > in /usr/obj/usr/src/amd64.amd64/sys/DUMMBOX/usr/ports/x11/nvidia-driver=
/work/NVIDIA-FreeBSD-x86_64-387.34/src/nvidia
> > *** Error code 2
> >=20
> >=20
> >=20
> > Oliver
> > =20
make -jX installkernel with the above mentioned setting of PORTS_MODULE=3D =
set
in /usr/src.conf doesn't wor even on recent CURRENT r328901.
make kernel doesn't fail.
oh
--=20
O. Hartmann
Ich widerspreche der Nutzung oder =C3=9Cbermittlung meiner Daten f=C3=BCr
Werbezwecke oder f=C3=BCr die Markt- oder Meinungsforschung (=C2=A7 28 Abs.=
4 BDSG).
--Sig_/VM=+vVrQKfdJb0xnMWBnlly
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature
-----BEGIN PGP SIGNATURE-----
iLUEARMKAB0WIQQZVZMzAtwC2T/86TrS528fyFhYlAUCWnjL/gAKCRDS528fyFhY
lD7RAf9Xd2j2xaDwQ3uzijGFe/YgSD2tW21DJDDUZgvGNE1WMaCyd/ctys4ZSAu7
UBQYAzdXB88tu5FXsYNV9i51eYx9AgCNfJgxbZ9/sVzkrWuqmnkeUF3kwo/IY6gj
C/QHiTXsKPNIC2uHK9n6RLEgumnOjsc6MnJjMl7HIpnh+PaS+vbh
=MNNn
-----END PGP SIGNATURE-----
--Sig_/VM=+vVrQKfdJb0xnMWBnlly--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180205222622.43f5d3e7>