From owner-freebsd-stable@FreeBSD.ORG Thu Jun 20 00:24:45 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 339807C7 for ; Thu, 20 Jun 2013 00:24:45 +0000 (UTC) (envelope-from kpaasial@gmail.com) Received: from mail-qc0-x232.google.com (mail-qc0-x232.google.com [IPv6:2607:f8b0:400d:c01::232]) by mx1.freebsd.org (Postfix) with ESMTP id EDECE19D2 for ; Thu, 20 Jun 2013 00:24:44 +0000 (UTC) Received: by mail-qc0-f178.google.com with SMTP id c11so3350664qcv.23 for ; Wed, 19 Jun 2013 17:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=YbVJsqrg45RpNzpB+c1vx/bXkOJAd1K6TiAc8Ze2vsc=; b=OmncWfoKi43CbSNS1Pa4OmI8hoNrszjINeT+uBXZvcgDfXcPBBltaYAH4cs3aCXjsm jrat7vF7lmIR3etith9I4vEd6/9hOAHuopo3APzkMF0tWFiLn/6lkgmlLRgY5FZ7Ra1f K5F0PxYjmx3dLJpyb8S0pSEJbtJPg6wOpElX128WjM9iVx/93GbPkwkvdbFrb9cckf5+ ihTrkspSeLCfd4GzCr50YOj/e5viJU5wdb0FNMtZNw6e23Tpypz4dJbEnQdm7Ek7KzKf Lxi4lQqrConzsuoev6FlGvuvHygiImCQrIKfoCISkfPvMUkqGjoRVf+roTxwjvh7IO2r 401Q== MIME-Version: 1.0 X-Received: by 10.224.1.2 with SMTP id 2mr6548485qad.38.1371687884506; Wed, 19 Jun 2013 17:24:44 -0700 (PDT) Received: by 10.224.182.148 with HTTP; Wed, 19 Jun 2013 17:24:44 -0700 (PDT) In-Reply-To: <51C2499B.2060209@quip.cz> References: <51C22E11.3020008@quip.cz> <51C23ED9.7070107@quip.cz> <51C2499B.2060209@quip.cz> Date: Thu, 20 Jun 2013 03:24:44 +0300 Message-ID: Subject: Re: sshd didn't run after upgrade to FreeBSD 8.4 From: Kimmo Paasiala To: Miroslav Lachman <000.fbsd@quip.cz> Content-Type: text/plain; charset=UTF-8 Cc: freebsd-stable Stable , Steven Hartland X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jun 2013 00:24:45 -0000 On Thu, Jun 20, 2013 at 3:15 AM, Miroslav Lachman <000.fbsd@quip.cz> wrote: > Kimmo Paasiala wrote: >> >> On Thu, Jun 20, 2013 at 2:40 AM, Steven Hartland >> wrote: >>> >>> >>> >>> I believe Miroslav is saying he left his old but previously working >>> sshd_config as was when updating, so its a change to the code which >>> now fails on an empty VersionAddendum, where it previously didn't >>> hence the problem. > > > Yes, this is my point - I left my old and previously working sshd_config > with empty VersionAddendum. > > >> Err yes, your right. The proper way to specify empty VersionAddendum >> based on some googling seems to be now: >> >> >> VersionAddendum "" > > > This is not true, it will add two quotes to the banner: > SSH-2.0-OpenSSH_6.1_hpn13v11 "" > > > Default banner (no VersionAddendum in sshd_config): > SSH-2.0-OpenSSH_6.1_hpn13v11 FreeBSD-20120901 > > > So I am fine with: > VersionAddendum - > > It will print: > SSH-2.0-OpenSSH_6.1_hpn13v11 - > > I don't need really empty addendum, I just don't want to show FreeBSD > version info and empty VersionAddendum was working for me many years. Now it > breaks sshd after final reboot on two of our upgraded servers. > > So Release Notes or better UPDATING entry will warn other users before the > same mistake. > > Thanks to the remote management / KVM on Sun Fire and Supermicro servers > that I didn't need to drive to the datacenter and I can fix it remotely. > > Miroslav Lachman Ok, this is crazy. If you put one space after the VersionAddendum keyword you get exactly what you want, an empty VersionAddendum string. If there's no space but a newline right after the VersionAddendum keyword, sshd(8) complains about the line and refuses to start. So this is ok (without the single quotes, they are just to show the endings of the lines): 'VersionAddendum ' But this is not: 'VersionAddendum' What are the OpenSSH devs thinking? -Kimmo