From nobody Tue Sep 9 18:52:04 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cLtGX4Rcnz67J7N; Tue, 09 Sep 2025 18:52:04 +0000 (UTC) (envelope-from jamie@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cLtGX3v7kz3sFb; Tue, 09 Sep 2025 18:52:04 +0000 (UTC) (envelope-from jamie@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757443924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sgcIsn2VeRh8nVGs2fRyCacgVIl3DxGoXlJtUxTtN3Y=; b=Ey8fskVj7nElD6uVCTUPb3BQzmLGy376a/YhiHprTGYf5GR6uTc0fKi+nnDrM+E6U3XHQI JRRVGiXKGepIEbaUgWs0S8DJPNgge11egHirvdpAwJ02QRL7EV0HxGJxH6v4fwc7TttYhg PIQN5lupA/7j7DitqQgc2jeV46H+BJFyqSYKoIwG6LTlXj8hgevfxfAWqMa7aLnCggXOZY 5f5rPbNePYdzBS2UllwccJRGpFScanszXos2GF5gPvzQ0o5CcKThT1hDJVgPzMAnI67iME o63F0qhyDX8Fhqs7sGbVOE8dDgcq2QPagl7Qu5QoODgsERU8hWnxi49wtMH8lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757443924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sgcIsn2VeRh8nVGs2fRyCacgVIl3DxGoXlJtUxTtN3Y=; b=Q00iB2XxI6bDDv2L/grmN312GTylVPTyPKuTe9bAZ+HjkOl59cFmSVzZ1au46OM+ySDWsH 9d25dD87ttdRYiB/GaQnDCeJc5aCKw3dR50SF3EAMdSX5Y0v56dCOhRdK6nVKKkDqA4ZHk FNDfSTonHRn+395RSCO9B47Z34tkioe71pQ8TUz5r1E4YZ41LVldfxsscBlL5YqhyiEod9 dNhPkINas9iVmthf/rggehrODC3mA4DzsfYRRkrusBaDOaBA6mkhLktoTWf5YATDviYtHd lIefEwPN6oFNXXZLVGi+P2oTitbnDWoVPd1iwr3HUYl6adBL1PS92ruJJ5VJPw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757443924; a=rsa-sha256; cv=none; b=TIRjAcXHJN/eerzxskU4dKSwvo+RzQHEwjRCa3WjM55DL0PX4rXZoVFBUTvc7PcpdRRN77 MnB5+uPuS6VX0CQ8weq7xW6lDUUAvA6bR6OuNeXPU6ydfyhZdpjgoR3kjUsHC0kHfqJcUt ZKIFwIUdwymxznljgfeOZ+/9x+rW1arBx7puq4P1fX5PNr7tMBLmEj8jGS2/3NWpoUbZSr pKw0qY1Lb3NoRhPNlhUbfm/XQw1DhW+vP9PM5xJD1sfov1tu6GA3y1rYOFoNVMQptAJVFV OINyJ07o9/q3DbMvWRwqth1I4wJD7QcBcdN67cAmWomWb/T7FpWDMRHQzm8V6w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from m2.gritton.org (gritton.org [67.43.236.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jamie) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cLtGX3GQdz21h; Tue, 09 Sep 2025 18:52:04 +0000 (UTC) (envelope-from jamie@freebsd.org) Received: from gritton.org (localgritton [127.0.0.212]) by m2.gritton.org (Postfix) with ESMTPSA id 2BC5379F8C; Tue, 9 Sep 2025 11:52:04 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Date: Tue, 09 Sep 2025 11:52:04 -0700 From: James Gritton To: Jessica Clarke Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 16f600dc30b7 - main - jaildesc: replace EBADF with EINVAL In-Reply-To: <9B159FF1-8D1D-4F1D-9CED-977EB0834403@freebsd.org> References: <202509091818.589II2D2005924@gitrepo.freebsd.org> <9B159FF1-8D1D-4F1D-9CED-977EB0834403@freebsd.org> Message-ID: X-Sender: jamie@freebsd.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2025-09-09 11:42, Jessica Clarke wrote: > On 9 Sep 2025, at 19:18, Jamie Gritton wrote: >> >> The branch main has been updated by jamie: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=16f600dc30b7bb82429660e540da802a1e3f7449 >> >> commit 16f600dc30b7bb82429660e540da802a1e3f7449 >> Author: Jamie Gritton >> AuthorDate: 2025-09-09 18:13:11 +0000 >> Commit: Jamie Gritton >> CommitDate: 2025-09-09 18:13:11 +0000 >> >> jaildesc: replace EBADF with EINVAL >> >> Following fd9e09cb, EBADF is not the suitable error code for a non- >> jail descriptor passed to jail_set, jail_get, jail_attach_fd, and >> jail_remove_fd. >> >> Reported by: kib > > Will you be MFC’ing this fix, the error checking one and any future > fixes to the new jaildesc code? The original jaildesc commit made it in > in time for stable/15 so will be part of 15.0, so either important > fixes need to be MFC’ed to ensure we release something without bugs or > it should be reverted in stable/15 and the whole series later MFC’ed > once deemed ready. Especially given the discussion about file object > ownership I’m a bit concerned that we have something in stable/15 that > has a design, rather than implementation, aspect that might be wrong, > and we really don’t want to be shipping a broken syscall ABI if so. > > Jessica Yes, I just forgot to set the MFC tag in the commit. This and some following commits are all slated for MFC. This will include the file permission API concerns, and the missing jail descriptor kevent support. Those are coming soon (next few days) but I'm pushing the low-hanging fruit out right now. - Jamie