From owner-freebsd-current@FreeBSD.ORG Sat Aug 2 20:01:51 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1E93F916 for ; Sat, 2 Aug 2014 20:01:51 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "funkthat.com", Issuer "funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E965627BD for ; Sat, 2 Aug 2014 20:01:50 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id s72K1nHL070804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 2 Aug 2014 13:01:49 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id s72K1n7k070803; Sat, 2 Aug 2014 13:01:49 -0700 (PDT) (envelope-from jmg) Date: Sat, 2 Aug 2014 13:01:49 -0700 From: John-Mark Gurney To: Svatopluk Kraus Subject: Re: domain_add(xxx) after domainfinalize... Message-ID: <20140802200149.GO50495@funkthat.com> Mail-Followup-To: Svatopluk Kraus , freebsd-current@freebsd.org References: <20140801193403.GE50495@funkthat.com> <20140801222118.GH50495@funkthat.com> <20140802183259.GL50495@funkthat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Sat, 02 Aug 2014 13:01:50 -0700 (PDT) Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Aug 2014 20:01:51 -0000 Svatopluk Kraus wrote this message on Sat, Aug 02, 2014 at 21:27 +0200: > On Sat, Aug 2, 2014 at 8:32 PM, John-Mark Gurney wrote: > > > Svatopluk Kraus wrote this message on Sat, Aug 02, 2014 at 15:20 +0200: > > > Well, I did not look at network stack for long time, so the following > > > things could be obsolete now, but at least: > > > > > > (1) There is some room left in mbuf header on its allocation, so > > protocols > > > (link) headers can be added in the front of data without need of > > > reallocation or data copying. The size of the room is evaluated from all > > > domains at boot time. > > > > > > (2) All network address masks are shared among domains and protocols in > > > mask radix tree. The tree is created with particular key size, which is > > > again evaluated from all domains as maximal size of all known addresses. > > > > > > So, if new domain added after these evaluations does not break both them > > > and some other things, there is no problem. Otherwise, some warnings are > > > always nice if things go bad. > > > > But would anyone who sees these issues know that this is the problem? > > And what would they do, report the problem? We'd say, yeh, we know, > > but do you hit this every day? Nope, ok, we won't fix it... > > > > > Maybe some function which examine new domain and say there is no risk to > > > add it would be nice. > > > > I agree... These things should have been done in the first place, but > > clearly this warning wasn't enough to cause anyone to fix it.. :) > > You are right, but the warning is remainder that there is something > unresolved. Remove the warning and forget, imho, it's not well. Sorry, nine years[1] of the warning existing yet no fix clearly demonstrates that it's already been forgoten, otherwise it would have been fixed by now.. Also, a bug report or XXX comment is enough IMO, and will probably receive the same amount of attention over the next nine years... [1] https://svnweb.freebsd.org/changeset/base/138239 -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."