From owner-p4-projects@FreeBSD.ORG  Thu May 29 13:22:24 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9CBF537B401; Thu, 29 May 2003 13:22:23 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3A84237B404
	for <perforce@freebsd.org>; Thu, 29 May 2003 13:22:23 -0700 (PDT)
Received: from mail.speakeasy.net (mail11.speakeasy.net [216.254.0.211])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 349A143F75
	for <perforce@freebsd.org>; Thu, 29 May 2003 13:22:22 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 13559 invoked from network); 29 May 2003 20:12:53 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
	(envelope-sender <jhb@FreeBSD.org>)encrypted SMTP
	for <perforce@freebsd.org>; 29 May 2003 20:12:53 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h4TKCpp0085303;
	Thu, 29 May 2003 16:12:51 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20030529161302.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.4 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200305291957.h4TJv7pq057342@repoman.freebsd.org>
Date: Thu, 29 May 2003 16:13:02 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Robert Watson <rwatson@FreeBSD.org>
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: RE: PERFORCE change 32034 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 May 2003 20:22:24 -0000


On 29-May-2003 Robert Watson wrote:
> http://perforce.freebsd.org/chv.cgi?CH=32034
> 
> Change 32034 by rwatson@rwatson_tislabs on 2003/05/29 12:56:54
> 
>       At some point, the mac_biba compartment subset logic seems
>       to have become inverted; return to logic wherein the Biba
>       dominate logic for a>=b uses:
>       
>               a.grade >= b.grade
>               a.compartment (superset) b.compartment
>       
>       This brings the _mac branch back into sync with the main
>       FreeBSD tree; I couldn't find a description for the reason
>       for this change, but if I missed it, please let me know.

Appears to have been in rev #189 of this file (new p4 client has annotate
support now):

Change 21367 by amigus@amigus_beetle on 2002/11/21 22:52:51

        Clean up parsing code (use strsep()) and introduce compartment
        range declaration and display.
        Biba/MLS now accepts and reports compartment sets using a '++'
        notation.  For example "mls/10:1++64" would denote level 10
        wih compartments 1 to 64.

Affected files ...

... //depot/projects/trustedbsd/mac/sys/security/mac_biba/mac_biba.c#189 edit
... //depot/projects/trustedbsd/mac/sys/security/mac_mls/mac_mls.c#150 edit

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/