From owner-svn-src-all@FreeBSD.ORG Mon Feb 16 19:26:58 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5F1AAFE3; Mon, 16 Feb 2015 19:26:58 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id D6B482F0; Mon, 16 Feb 2015 19:26:57 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t1GJQsGH055635 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 16 Feb 2015 22:26:54 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t1GJQstu055634; Mon, 16 Feb 2015 22:26:54 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 16 Feb 2015 22:26:54 +0300 From: Gleb Smirnoff To: Julian Elischer Subject: Re: svn commit: r278640 - head/sys/netgraph Message-ID: <20150216192653.GI15484@FreeBSD.org> References: <201502122220.t1CMKY8t040498@svn.freebsd.org> <20150214000540.GI15484@FreeBSD.org> <54E1D03A.2070904@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54E1D03A.2070904@freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, mav@FreeBSD.org, src-committers@freebsd.org, svn-src-all@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 19:26:58 -0000 On Mon, Feb 16, 2015 at 03:10:50AM -0800, Julian Elischer wrote: J> On 2/13/15 4:05 PM, Gleb Smirnoff wrote: J> > Hi! J> > J> > On Thu, Feb 12, 2015 at 10:20:34PM +0000, Gleb Smirnoff wrote: J> > T> Author: glebius J> > T> Date: Thu Feb 12 22:20:34 2015 J> > T> New Revision: 278640 J> > T> URL: https://svnweb.freebsd.org/changeset/base/278640 J> > T> J> > T> Log: J> > T> Revise default limit for maximum of netgraph data items. J> > T> With modern internet speeds the limit can be reached even J> > T> on a single L2TP link. J> > J> > Actually any ng_item of data type requires an mbuf to be connected J> > to it, and thus I suggest to use mbuf limits to drive ng_item limits. J> > J> > If we got an item leak with mbufs being properly freed, then we've J> > got a bug to fix, and any limit won't work in long run time. I never J> > evidenced such a bug, but there complaints on hitting limit at J> > traffic bursts. As said, with previous 512 item limit I experienced J> > that even on a laptop. J> > J> > Any objections on removing the limit, guys? J> maybe derived from it, but not the same number. J> maybe change the systctl to define the relationship? I guess you want to have ng_items limit smaller than mbuf limit? How smaller? What problem are we actually guarding against putting this limit? -- Totus tuus, Glebius.