From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Apr 29 19:50:04 2007 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E874F16A400 for ; Sun, 29 Apr 2007 19:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id BF25C13C46C for ; Sun, 29 Apr 2007 19:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l3TJo32R048725 for ; Sun, 29 Apr 2007 19:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l3TJo3Wq048724; Sun, 29 Apr 2007 19:50:03 GMT (envelope-from gnats) Resent-Date: Sun, 29 Apr 2007 19:50:03 GMT Resent-Message-Id: <200704291950.l3TJo3Wq048724@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Marcin Wisnicki Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8F55B16A401 for ; Sun, 29 Apr 2007 19:41:58 +0000 (UTC) (envelope-from mwisnicki@gmail.com) Received: from mu-out-0910.google.com (mu-out-0910.google.com [209.85.134.188]) by mx1.freebsd.org (Postfix) with ESMTP id 1E7A413C448 for ; Sun, 29 Apr 2007 19:41:57 +0000 (UTC) (envelope-from mwisnicki@gmail.com) Received: by mu-out-0910.google.com with SMTP id g7so1510098muf for ; Sun, 29 Apr 2007 12:41:56 -0700 (PDT) Received: by 10.82.185.12 with SMTP id i12mr10446161buf.1177875716356; Sun, 29 Apr 2007 12:41:56 -0700 (PDT) Received: from ghost.pnet.one.pl ( [84.40.242.20]) by mx.google.com with ESMTP id b33sm44973ika.2007.04.29.12.41.55; Sun, 29 Apr 2007 12:41:55 -0700 (PDT) Received: by ghost.pnet.one.pl (sSMTP sendmail emulation); Sun, 29 Apr 2007 21:41:53 +0200 Message-Id: <4634f503.755b5ed6.652d.0432@mx.google.com> Date: Sun, 29 Apr 2007 21:41:53 +0200 From: Marcin Wisnicki Sender: =?UTF-8?B?TWFyY2luIFdpxZtuaWNraQ==?= To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: lioux@FreeBSD.org Subject: ports/112253: [PATCH] net-p2p/mldonkey: rc script broken X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2007 19:50:04 -0000 >Number: 112253 >Category: ports >Synopsis: [PATCH] net-p2p/mldonkey: rc script broken >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Apr 29 19:50:03 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Marcin Wisnicki >Release: FreeBSD 6.2-STABLE i386 >Organization: >Environment: System: FreeBSD ghost.pnet.one.pl 6.2-STABLE FreeBSD 6.2-STABLE #5: Sat Feb 10 23:20:51 CET 2007 >Description: Redirection depends on sh syntax which is not availible in tcsh. Su executes command in default login shell which on some systems might be tcsh or something else. Proposed patch explicitly calls /bin/sh. Another solution would be to execute "daemon -f ${command} ..." instead of redirection, which I used before with success. Of course, same thing applies to mldonkey-devel. Port maintainer (lioux@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.77 >How-To-Repeat: set ${mlnet_user} to someone with non-bourne shell # /usr/local/etc/rc.d/mlnet start Ambiguous output redirect. >Fix: --- mldonkey-2.8.5.patch begins here --- diff -ruN --exclude=CVS /usr/ports/net-p2p/mldonkey.orig/files/mlnet.in /usr/ports/net-p2p/mldonkey/files/mlnet.in --- /usr/ports/net-p2p/mldonkey.orig/files/mlnet.in Sat Dec 23 03:56:55 2006 +++ /usr/ports/net-p2p/mldonkey/files/mlnet.in Sun Apr 29 21:27:27 2007 @@ -59,10 +59,10 @@ ${mlnet_flags} \ >> ${mlnet_logfile} 2>&1 &" else - su -l ${mlnet_user} -c "${command} \ + su -l ${mlnet_user} -c "/bin/sh -c \"${command} \ ${mlnet_logcommand} \ ${mlnet_flags} \ - >> ${mlnet_logfile} 2>&1 &" + >> ${mlnet_logfile} 2>&1 &\"" fi } --- mldonkey-2.8.5.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: