From owner-svn-src-all@freebsd.org Mon May 6 14:42:04 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 47593158CBEB; Mon, 6 May 2019 14:42:04 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CCE4672A3E; Mon, 6 May 2019 14:42:03 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 89DA514B0A; Mon, 6 May 2019 14:42:03 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f169.google.com with SMTP id q10so11315557ljc.6; Mon, 06 May 2019 07:42:03 -0700 (PDT) X-Gm-Message-State: APjAAAXLpa0nvQwc+k5GSeqpyvS5aB7IrZ/OigUVY685v/Y+nuY6B1HF fugDSoM/Uf+uOg337M3Q5GPf+Ql+mdXRvbbq6Aw= X-Google-Smtp-Source: APXvYqxv/n3sbKxZeByFoKDSxfo9Ih9vn95TETa78KzXp13xCcdKriG3rQC5sCroKht4S9MvwUSGFitg+Yu+VJBZEdA= X-Received: by 2002:a2e:9a17:: with SMTP id o23mr4303621lji.108.1557153721956; Mon, 06 May 2019 07:42:01 -0700 (PDT) MIME-Version: 1.0 References: <201905060948.x469mZiw004587@repo.freebsd.org> In-Reply-To: <201905060948.x469mZiw004587@repo.freebsd.org> From: Kyle Evans Date: Mon, 6 May 2019 09:41:23 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r347183 - head/sys/geom To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: CCE4672A3E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.945,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 May 2019 14:42:04 -0000 On Mon, May 6, 2019 at 4:48 AM Roger Pau Monn=C3=A9 wr= ote: > > Author: royger > Date: Mon May 6 09:48:34 2019 > New Revision: 347183 > URL: https://svnweb.freebsd.org/changeset/base/347183 > > Log: > geom: fix initialization order > > There's a race between the initialization of devsoftc.mtx (by devinit) > and the creation of the geom worker thread g_run_events, which calls > devctl_queue_data_f. Both of those are initialized at SI_SUB_DRIVERS > and SI_ORDER_FIRST, which means the geom worked thread can be created > before the mutex has been initialized, leading to the panic below: > > wpanic: mtx_lock() of spin mutex (null) @ /usr/home/osstest/build.1353= 17.build-amd64-freebsd/freebsd/sys/kern/subr_bus.c:620 > cpuid =3D 3 > time =3D 1 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00= 3b968710 > vpanic() at vpanic+0x19d/frame 0xfffffe003b968760 > panic() at panic+0x43/frame 0xfffffe003b9687c0 > __mtx_lock_flags() at __mtx_lock_flags+0x145/frame 0xfffffe003b968810 > devctl_queue_data_f() at devctl_queue_data_f+0x6a/frame 0xfffffe003b96= 8840 > g_dev_taste() at g_dev_taste+0x463/frame 0xfffffe003b968a00 > g_load_class() at g_load_class+0x1bc/frame 0xfffffe003b968a30 > g_run_events() at g_run_events+0x197/frame 0xfffffe003b968a70 > fork_exit() at fork_exit+0x84/frame 0xfffffe003b968ab0 > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe003b968ab0 > --- trap 0, rip =3D 0, rsp =3D 0, rbp =3D 0 --- > KDB: enter: panic > [ thread pid 13 tid 100029 ] > Stopped at kdb_enter+0x3b: movq $0,kdb_why > > Fix this by initializing geom at SI_ORDER_SECOND instead of > SI_ORDER_FIRST. > > Sponsored by: Citrix Systems R&D > Reviewed by: kevans, markj > Differential revision: https://reviews.freebsd.org/D20148 > Hi, Any objections to my MFC'ing this on ~Thursday with the tun change that sparked it? Thanks, Kyle Evans