Date: Fri, 8 Sep 2023 17:01:52 +0200 From: Guido Falsi <madpilot@FreeBSD.org> To: Charlie Li <vishwin@freebsd.org>, Matthias Fechner <mfechner@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: f11ed4160472 - main - devel/libgit2: update to 1.6.4 Message-ID: <c72cd08e-6cf1-7db6-d4af-0ab43af78718@FreeBSD.org> In-Reply-To: <360a5750-d765-0ef3-99fc-30997e997abd@freebsd.org> References: <202309081035.388AZWKP075486@gitrepo.freebsd.org> <6e61cd7f-fa81-a6e9-f601-996a3a21162b@FreeBSD.org> <360a5750-d765-0ef3-99fc-30997e997abd@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08/09/23 16:09, Charlie Li wrote: > Guido Falsi wrote: >> The commit which added the patch to fix this is here: >> >> https://cgit.freebsd.org/ports/commit/devel/libgit2?id=a62f1b5796b641bb502b33f7f073238a49dc4d0c >> >> >> Looking at upstream it looks like this fix is included there only >> starting from version 1.7.0 (correct me if I'm wrong) >> >> I'll take a look at adding back the patch. >> > I have 1.7.1 locally without any additional patching. However, we may > need an additional ${CMAKE_ARGS} to pass ${OPENSSLBASE} so that CMake > picks up the correct USES=ssl implementation, because it's > unconditionally picking up the base system one. > Updating to an even newer version would be good too. Hoping getting it to take the correct ssl library is that easy and does not require cmake changes. Anyway I'm testing adding back the patch keeping version 1.6.4 for now, which looks like the safest and quickest path to fixing things. -- Guido Falsi <madpilot@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c72cd08e-6cf1-7db6-d4af-0ab43af78718>