From owner-freebsd-bugs@FreeBSD.ORG  Fri Aug 15 06:20:15 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B931237B401
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 15 Aug 2003 06:20:15 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5A6F343F85
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 15 Aug 2003 06:20:15 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h7FDKEUp085189
	for <freebsd-bugs@freefall.freebsd.org>;
	Fri, 15 Aug 2003 06:20:14 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h7FDKEXq085188;
	Fri, 15 Aug 2003 06:20:14 -0700 (PDT)
Date: Fri, 15 Aug 2003 06:20:14 -0700 (PDT)
Message-Id: <200308151320.h7FDKEXq085188@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Eugene Grosbein <eugen@grosbein.pp.ru>
Subject: Re: bin/55346: /bin/sh eats memory and CPU infinitely
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Eugene Grosbein <eugen@grosbein.pp.ru>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Aug 2003 13:20:16 -0000

The following reply was made to PR bin/55346; it has been noted by GNATS.

From: Eugene Grosbein <eugen@grosbein.pp.ru>
To: stable@freebsd.org
Cc: bug-followup@freebsd.org
Subject: Re: bin/55346: /bin/sh eats memory and CPU infinitely
Date: Fri, 15 Aug 2003 21:13:21 +0800

 I think I've found a memory leak in /bin/sh.
 There is a case when dowait() and does frees resources of
 completed job correctly. Here is a patch:
 
 Index: jobs.c
 ===================================================================
 RCS file: /home/ncvs/src/bin/sh/jobs.c,v
 retrieving revision 1.27.2.11
 diff -u -r1.27.2.11 jobs.c
 --- jobs.c	22 Jul 2003 13:11:26 -0000	1.27.2.11
 +++ jobs.c	15 Aug 2003 13:02:23 -0000
 @@ -960,10 +960,8 @@
  				if (jp->state != state) {
  					TRACE(("Job %d: changing state from %d to %d\n", jp - jobtab + 1, jp->state, state));
  					jp->state = state;
 -#if JOBS
  					if (done)
 -						deljob(jp);
 -#endif
 +					    freejob(jp);
  				}
  			}
  		}
  
 Eugene Grosbein