From owner-freebsd-current@FreeBSD.ORG Thu Jul 7 12:43:23 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CF3EE106564A for ; Thu, 7 Jul 2011 12:43:23 +0000 (UTC) (envelope-from moonlightakkiy@yahoo.ca) Received: from nm30-vm4.bullet.mail.ne1.yahoo.com (nm30-vm4.bullet.mail.ne1.yahoo.com [98.138.91.190]) by mx1.freebsd.org (Postfix) with SMTP id 871658FC0A for ; Thu, 7 Jul 2011 12:43:23 +0000 (UTC) Received: from [98.138.90.50] by nm30.bullet.mail.ne1.yahoo.com with NNFMP; 07 Jul 2011 12:43:23 -0000 Received: from [98.138.84.44] by tm3.bullet.mail.ne1.yahoo.com with NNFMP; 07 Jul 2011 12:43:23 -0000 Received: from [127.0.0.1] by smtp112.mail.ne1.yahoo.com with NNFMP; 07 Jul 2011 12:43:23 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.ca; s=s1024; t=1310042603; bh=3KQH8DpPJQG2es6X3rCQnOs1ctsX8p4T8szQBBMyMzQ=; h=X-Yahoo-Newman-Id:Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:Received:MIME-Version:Received:Received:In-Reply-To:References:Date:Message-ID:Subject:From:To:Cc:Content-Type; b=Nj7O4ziPy6pk3GJHIRs0JtvxhQ6P/aDoj9XfFerXV920EJ/6A0JzquxIISz4ACWBFot1pOLHLaLESyRXb/Qu+9SBVHV71kFR/+a2LSsNU5V7b+pQF/j+aX/vZGTOn4eZqdCibZWEtg2RkaI+alibPJ4CRuOA1Z5+Vp81Wc/HVk0= X-Yahoo-Newman-Id: 146553.26040.bm@smtp112.mail.ne1.yahoo.com Received: from mail-vw0-f54.google.com (moonlightakkiy@209.85.212.54 with plain) by smtp112.mail.ne1.yahoo.com with SMTP; 07 Jul 2011 05:43:23 -0700 PDT X-Yahoo-SMTP: Xr6qjFWswBAEmd20sAvB4Q3keqXvXsIH9TjJ X-YMail-OSG: _x.QiigVM1kzqQ2xIJzb0Q2jrsreoDNSPW5w2Kt8UIXOQck _C63YjU4YEz13GUJm2XZbkJIk10TyLLBVKSUCoHrwoL6o279NndktcxO131w ONjE4NaCBunRe_cZ7xiwL0riylkq85nVVUUcTehXcQ.nuyIkBCT1rDwms423 UaL_A.uOBgERgPLmLYEqLmOkaPOOJhAre7qgV3..K4UVOjMUsWjBEftgE4KK U6aEy7PgPTJx3zFP1f086C37ZtlI._X6QyjUHL6k3alO99XLNDwC71yTVJHa W5zFRoCBpDxWPKV7i4UXpBoygClnWuuLSMzqRICGWoQXNBjNmoy5mlFtmMGQ Tdl713h7EiLL3SeBRYnh_FInQFwn64ZPzSY_NiWTcHhvxhJFmZuK46tX4xIe 3q1VHHLCdxu2GoRvyJNYXSs0PIwuhW2o4gUlDzH2uFR49i595rQrRWaU1YDI DoVzGYtyeIF2peL6VCFHvrXqG_KwdX4kFUFKpCsazPYQ- X-Yahoo-Newman-Property: ymail-3 Received: by vws18 with SMTP id 18so900260vws.13 for ; Thu, 07 Jul 2011 05:43:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.179.131 with SMTP id dg3mr1101300vdc.9.1310042602467; Thu, 07 Jul 2011 05:43:22 -0700 (PDT) Received: by 10.52.108.229 with HTTP; Thu, 7 Jul 2011 05:43:22 -0700 (PDT) In-Reply-To: <201107061719.38445.hselasky@c2i.net> References: <1309237117.88943.YahooMailNeo@web39307.mail.mud.yahoo.com> <201106280850.57645.hselasky@c2i.net> <201107061719.38445.hselasky@c2i.net> Date: Thu, 7 Jul 2011 06:43:22 -0600 Message-ID: From: PseudoCylon To: Hans Petter Selasky Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-current@freebsd.org, "freebsd-wireless@freebsd.org" Subject: Re: [CFT] Sierra Wireless HSPA+ USB modem X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2011 12:43:23 -0000 On Wed, Jul 6, 2011 at 9:19 AM, Hans Petter Selasky wrote: >> >> Hi, >> >> I'm going to review and import your driver. >> >> --HPS > > Hi, > > The intial patch had some bad code and didn't compile on 9-current. I've tried > to clean it up. Please test and report back if I didn't break anything. > > http://hselasky.homeunix.org:8192/usie_for_FreeBSD_9_current.patch > > --HPS > Hello, Thanks for the patch. if_usie.c 241 if (usbd_lookup_id_by_uaa(usie_devs, sizeof(usie_devs), uaa) != 0) 242 return; /* no device match */ It should return non-zero on success, but somehow this caused the process to exit, and modem stayed being a CD-ROM. The compiler complained about uninitialized int if_usie.c: 1484 - uint8_t pad; + uint8_t pad = 0; Otherwise it worked fine. AK