From owner-cvs-all  Wed Dec  8 11:44: 6 1999
Delivered-To: cvs-all@freebsd.org
Received: from bubba.whistle.com (bubba.whistle.com [207.76.205.7])
	by hub.freebsd.org (Postfix) with ESMTP
	id E936F156ED; Wed,  8 Dec 1999 11:44:03 -0800 (PST)
	(envelope-from archie@whistle.com)
Received: (from archie@localhost)
	by bubba.whistle.com (8.9.2/8.9.2) id LAA51275;
	Wed, 8 Dec 1999 11:42:57 -0800 (PST)
From: Archie Cobbs <archie@whistle.com>
Message-Id: <199912081942.LAA51275@bubba.whistle.com>
Subject: Re: cvs commit: src/usr.bin/whois whois.c
In-Reply-To: <384E09C3.735C0F6C@softweyr.com> from Wes Peters at "Dec 8, 1999 00:33:23 am"
To: wes@softweyr.com (Wes Peters)
Date: Wed, 8 Dec 1999 11:42:57 -0800 (PST)
Cc: joe@pavilion.net (Josef Karthauser), cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

Wes Peters writes:
> > I thought that it was _explicity_ required!  That way when someone visits
> > the code later they don't need to worry about breaking code because of missing
> > braces.  (A major cause of software bug, is it not?)
> 
> FWIW, I'm with you on this one.  I've seen way too many bugs over the years
> where somebody inserted another statement, "properly" indented, expecting it
> to be executed along with the original one.  Our current stance on this issue
> is assinine and self-defeating.  On the other hand, every project really needs
> a style guide and even a bad one is better than none at all.  I'll follow what
> we have and keep lobbying to get it fixed.

I guess this is a personal preference thing, but.. in my opinion
if you are inserting statements without checking the simple brace
syntax and logic then you are too careless to be a committer.

Seat belts are ugly and save lives.  Extra braces are ugly and
save careless committers, which is not as important :-)

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message