Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 09 Sep 2019 13:44:13 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 240445] ports-mgmt/portlint: PYQT-related false positives
Message-ID:  <bug-240445-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240445

            Bug ID: 240445
           Summary: ports-mgmt/portlint: PYQT-related false positives
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: marcus@FreeBSD.org
          Reporter: vladimir.chukharev@gmail.com
          Assignee: marcus@FreeBSD.org
             Flags: maintainer-feedback?(marcus@FreeBSD.org)
 Attachment #207325 maintainer-approval?
             Flags:

Created attachment 207325
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D207325&action=
=3Dedit
Patch

Hi,

portlint gives false positives about PYQT related variables. This can be se=
en
with the following.
$ ( cd /usr/ports/graphics/py-traitsui ; portlint -Ca )
WARN: Makefile: When USES=3Dpyqt:5 is defined, you must also define USE_PYQ=
T=3Dxxxx
0 fatal errors and 1 warning found.

A discussion can found at https://reviews.freebsd.org/D21229 .

I propose a patch adding USE_PYQT to @varlist and checking $makevar if stat=
ic
text analysis does not find the variable. This fixes the bug for me, but you
better carefully test the patch, since I do not use Perl myself.

The patch also bumps the port version, sorry if that disturbs...

QA:
port test : OK
poudriere : OK
portlint -Ca: OK

Vladimir

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-240445-7788>