From owner-freebsd-ports@FreeBSD.ORG Sun Feb 12 20:45:58 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 36D681065670 for ; Sun, 12 Feb 2012 20:45:58 +0000 (UTC) (envelope-from stephen@missouri.edu) Received: from wilberforce.math.missouri.edu (wilberforce.math.missouri.edu [128.206.184.213]) by mx1.freebsd.org (Postfix) with ESMTP id E71BD8FC13 for ; Sun, 12 Feb 2012 20:45:57 +0000 (UTC) Received: from [127.0.0.1] (wilberforce.math.missouri.edu [128.206.184.213]) by wilberforce.math.missouri.edu (8.14.5/8.14.5) with ESMTP id q1CKjuYL017007; Sun, 12 Feb 2012 14:45:56 -0600 (CST) (envelope-from stephen@missouri.edu) Message-ID: <4F382504.10802@missouri.edu> Date: Sun, 12 Feb 2012 14:45:56 -0600 From: Stephen Montgomery-Smith User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.26) Gecko/20120131 Thunderbird/3.1.18 MIME-Version: 1.0 To: Steve Kargl References: <20120212193927.GA86426@troutmask.apl.washington.edu> <20120212201624.GA86650@troutmask.apl.washington.edu> <4F3820AD.4090702@FreeBSD.org> <20120212204118.GA86775@troutmask.apl.washington.edu> In-Reply-To: <20120212204118.GA86775@troutmask.apl.washington.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Chris Rees , freebsd-ports@freebsd.org, Andriy Gapon Subject: Re: Please test your commits X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Feb 2012 20:45:58 -0000 On 02/12/2012 02:41 PM, Steve Kargl wrote: > On Sun, Feb 12, 2012 at 10:27:25PM +0200, Andriy Gapon wrote: >> on 12/02/2012 22:16 Steve Kargl said the following: >>> You seem to have the faulty belief that this is the first occurence >>> of this type of issue? >> >> So instead of proper report to the port's maintainer (including description of >> your environment, possibly full build log, etc), possibly with a CC here, you >> decided to vent out here... >> >> Is there any requirement that people do the former and not the latter? :-) >> > > I'm not venting. I'm simply requesting that all committers > test the code that they intend to commit. It is quite > clear that this particular commit was not tested. > > The environment is irrelevant because malloc.h was poisoned > 10 years, 3 months ago. As to a full build log, the > necessary information was included in my original email. Except I didn't get the malloc.h error when I tried compiling it. So merely noting the age of malloc.h doesn't prove that the committer didn't test it.