From owner-freebsd-java@FreeBSD.ORG Sun Sep 15 09:45:25 2013 Return-Path: Delivered-To: java@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 27D41FDD; Sun, 15 Sep 2013 09:45:25 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9EB412845; Sun, 15 Sep 2013 09:45:24 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::2dfe:a80e:4c91:edd0] (unknown [IPv6:2001:7b8:3a7:0:2dfe:a80e:4c91:edd0]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 4D1685C44; Sun, 15 Sep 2013 11:45:22 +0200 (CEST) Content-Type: multipart/signed; boundary="Apple-Mail=_C82A5FEB-637E-43BE-AA7C-B57FCB1E84EF"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: Building java/openjdk7 with clang From: Dimitry Andric In-Reply-To: <20130915060706.GH41229@kib.kiev.ua> Date: Sun, 15 Sep 2013 11:45:09 +0200 Message-Id: References: <108F3771-64B3-40E9-91FA-04C160442608@FreeBSD.org> <20130915060706.GH41229@kib.kiev.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.1510) Cc: java@FreeBSD.org, Baptiste Daroussin , Greg Lewis X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2013 09:45:25 -0000 --Apple-Mail=_C82A5FEB-637E-43BE-AA7C-B57FCB1E84EF Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On Sep 15, 2013, at 08:07, Konstantin Belousov wrote: > On Sun, Sep 15, 2013 at 01:45:19AM +0200, Dimitry Andric wrote: ... >> - Change the $(CC) -dumpspecs hack in one of the Makefiles to something >> more portable. The -dumpspecs is done to figure out if the compiler >> uses --hash-style=gnu when linking, and if it does, it changes the >> option to --hash-style=both. On FreeBSD, this is basically a no-op, > Compiler ? Do you reference the ELF hash there ? Why do you think this is > nop ? Before your r236137 in head, our gcc did not pass --hash-style at all, afterwards it passes --hash-style=both (for dynamic executables). Similar for our clang, before and after r236258. So grepping for --hash-style=gnu in the verbose output will never give a hit, and the JDK Makefile will never add an explicit --hash-style=both argument. Therefore, for FreeBSD, the whole block is effectively a nop. Maybe the change from -dumpspecs to a small link operation using -v can be sent upstream, so it works for all compilers. -Dimitry --Apple-Mail=_C82A5FEB-637E-43BE-AA7C-B57FCB1E84EF Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) iEYEARECAAYFAlI1gbAACgkQsF6jCi4glqPOKQCg4z5P2X6cOSefpX4qVxfmKDIH /B0AoPPDyXMv5vk939kDjIkY/YsduqH3 =zUJA -----END PGP SIGNATURE----- --Apple-Mail=_C82A5FEB-637E-43BE-AA7C-B57FCB1E84EF--