From owner-freebsd-ports@FreeBSD.ORG Thu May 26 19:41:19 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA6AB106564A for ; Thu, 26 May 2011 19:41:19 +0000 (UTC) (envelope-from crawford.6@sociology.osu.edu) Received: from mail.sociology.ohio-state.edu (mail.sociology.ohio-state.edu [140.254.146.4]) by mx1.freebsd.org (Postfix) with SMTP id 8EB888FC1B for ; Thu, 26 May 2011 19:41:19 +0000 (UTC) Received: (qmail 30491 invoked by uid 1224); 26 May 2011 19:14:37 -0000 Received: from hub.sociology.ohio-state.edu by mail.sociology.ohio-state.edu (envelope-from , uid 82) with qmail-scanner-2.06 (clamdscan: 0.97/13113. Clear:RC:1(140.254.146.1):. Processed in 0.038708 secs); 26 May 2011 19:14:37 -0000 Received: from hub.sociology.ohio-state.edu (140.254.146.1) by smtp.sociology.ohio-state.edu with SMTP; 26 May 2011 19:14:37 -0000 Received: from localhost (localhost [127.0.0.1]) by hub.sociology.ohio-state.edu (Postfix) with ESMTP id 0D0DEACA002; Thu, 26 May 2011 15:14:37 -0400 (EDT) X-Virus-Scanned: amavisd-new at hub.sociology.ohio-state.edu Received: from hub.sociology.ohio-state.edu ([127.0.0.1]) by localhost (hub.sociology.ohio-state.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nrDaituN-qd5; Thu, 26 May 2011 15:14:36 -0400 (EDT) Received: from hub.sociology.ohio-state.edu (hub.sociology.ohio-state.edu [140.254.146.1]) by hub.sociology.ohio-state.edu (Postfix) with ESMTP id A5464ACA001; Thu, 26 May 2011 15:14:36 -0400 (EDT) Date: Thu, 26 May 2011 15:14:36 -0400 (EDT) From: J crawford To: freebsd-ports@freebsd.org Message-ID: <7258354.35678.1306437276615.JavaMail.root@hub> In-Reply-To: <14980146.3752.1300993458946.JavaMail.root@hub> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [140.254.146.224] X-Mailer: Zimbra 6.0.12_GA_2888 (ZimbraWebClient - FF3.0 (Win)/6.0.12_GA_2883) Cc: roam@FreeBSD.org Subject: daemontools functionality changes with patch X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2011 19:41:20 -0000 Concerning sysutils / daemontools port I don't favor the addition of the "Add Gerritt Pape's patch to skip the timestamp when matching incoming log messages against the specified patterns." to the daemontools port. multilog then does not function as described in the documentation. man multilog Patterns apply to the line after the timestamp is inserted. That's a pretty large change in functionality, undocumented in the accompanying man pages and not matching the documentation of http://cr.yp.to/daemontools/multilog.html Could you consider modification of the port so that this is change in functionality is removed (or optionally configurable with a warning)? By the way, Gerrit's name is misspelled with two t's in the change comment and patch code. Thanks for Roam's contributions to the FreeBSD project. Sincerely, John Crawford