From owner-svn-src-all@freebsd.org Mon Mar 27 17:40:05 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E0D67D20A51 for ; Mon, 27 Mar 2017 17:40:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22d.google.com (mail-it0-x22d.google.com [IPv6:2607:f8b0:4001:c0b::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B07517E1 for ; Mon, 27 Mar 2017 17:40:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22d.google.com with SMTP id e75so28536697itd.1 for ; Mon, 27 Mar 2017 10:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=iv71L95SuEQUl6NOly5QYv8Ja2wWSt7V6x6PEK0YZv4=; b=OPH8GvMe23TYINLsfwMzZjo9ApaouJnAo88c62EWCj6X1BgoVpzm3V6HjdnIN4mW2B XyoBJCx2BN6O6zkYZFfHNernUklkOR/mUxRyh+FkGoeFMMf8UXYrsz8R1qgIE5sctWwF XmKHiFimqCUHkuEoZ0O8lOP9ogN+9C6RAJeVWgjHhiQKm9d0zZeYWH6D+2lyp/clYSNW Jy2XuHKziRme1UJdp/+zFkeVHgqPyjEPHWI7Nv5XWv27SA3QqnVCNNliz1PCqKcYiFw0 B8K20fzcN8r4YzRI0cvvtxGC00zZqnpvcDnXMwu0NRCsPdN50HO4hFJjFMJuBt9iipPE 5/aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=iv71L95SuEQUl6NOly5QYv8Ja2wWSt7V6x6PEK0YZv4=; b=i64W/p+zxkR7IuIVKoz9mXURCthAj0vas93p57ktmRa8nLCJ9bqB0GyCSHLWh32rl0 7IkjP27bhr1iTEuf2MeNG1wmw9DaWqQizaRsHkaRjdvJA+1uowR8t5jT7rjpGALvM0qn IuQPBdE6BB8BK+Y+kBBxu0qCsqpbP2DTswh8AofU/MVNGzxHm0AVwQOrhNiQYAmSD5A2 ss+qO/xPoHQ7vwHW8d7a/x3HXdlFfpLE8USt+cEolOTPCuvsLZI3mTOPzsfW7aaN1x5n xP0EMFenlB6bGPXhE+BXnZNGL8lHWeL++p1oaOnEjWQbnVZIxij1gonJkKCFhzQsZ688 /E6A== X-Gm-Message-State: AFeK/H2n+3vCxPsrlWWcsz9O3Iq2tsuESqGQP++i+KV0q4NPdht8ItOSHebsRo83hMqd0SzTmU8INYqreoJgBA== X-Received: by 10.36.212.129 with SMTP id x123mr10484632itg.103.1490636403736; Mon, 27 Mar 2017 10:40:03 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.146.24 with HTTP; Mon, 27 Mar 2017 10:40:03 -0700 (PDT) X-Originating-IP: [50.253.99.174] In-Reply-To: <1579704.6DjZ3RBGJe@ralph.baldwin.cx> References: <201703260836.v2Q8auoU069005@repo.freebsd.org> <1579704.6DjZ3RBGJe@ralph.baldwin.cx> From: Warner Losh Date: Mon, 27 Mar 2017 11:40:03 -0600 X-Google-Sender-Auth: 0ARsp_fpLSv7x7WrytZMRbcSVqE Message-ID: Subject: Re: svn commit: r315974 - in head: lib/libthread_db/arch/arm sys/arm/arm sys/arm/include To: John Baldwin Cc: Michal Meloun , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2017 17:40:06 -0000 On Mon, Mar 27, 2017 at 11:07 AM, John Baldwin wrote: > On Sunday, March 26, 2017 08:36:56 AM Michal Meloun wrote: >> Author: mmel >> Date: Sun Mar 26 08:36:56 2017 >> New Revision: 315974 >> URL: https://svnweb.freebsd.org/changeset/base/315974 >> >> Log: >> Preserve VFP state across signal delivery. >> >> We don't have enouch space to store full VFP context within mcontext >> stucture. Due to this: >> - follow i386/amd64 way and store VFP state outside of the mcontext_t >> but point to it. Use the size of VFP state structure as an 'magic' >> indicator of the saved VFP state presence. >> - teach set_mcontext() about this external storage. >> - for signal delivery, store VFP state to expanded 'struct sigframe'. >> >> Submited by: Andrew Gierth (initial version) >> PR: 217611 >> MFC after: 2 weeks >> >> Modified: >> head/lib/libthread_db/arch/arm/libpthread_md.c >> head/sys/arm/arm/machdep.c >> head/sys/arm/include/frame.h >> head/sys/arm/include/ucontext.h >> >> Modified: head/lib/libthread_db/arch/arm/libpthread_md.c >> ============================================================================== >> --- head/lib/libthread_db/arch/arm/libpthread_md.c Sun Mar 26 08:36:20 2017 (r315973) >> +++ head/lib/libthread_db/arch/arm/libpthread_md.c Sun Mar 26 08:36:56 2017 (r315974) >> @@ -90,7 +90,9 @@ pt_fpreg_to_ucontext(const struct fpreg >> mcontext_t *mc = &uc->uc_mcontext; >> >> /* XXX */ >> - memset(&mc->mc_spare, 0, sizeof(mc->mc_spare)); >> + mc->mc_vfp_size = 0; >> + mc->mc_vfp_ptr = NULL; >> + memset(mc->mc_spare, 0, sizeof(mc->mc_spare)); >> } > > I suspect you don't need this bit? Has FreeBSD/arm ever supported VFP on a release > that also shipped libkse? (i.e. not libthr but the other thread library) No. And even if we had, we blew up binary compat when we went from OABI to EABI. Warner