From owner-freebsd-stable@FreeBSD.ORG Fri Apr 28 05:29:56 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D3D5B16A40F for ; Fri, 28 Apr 2006 05:29:56 +0000 (UTC) (envelope-from gene@nttmcl.com) Received: from mx2.nttmcl.com (MX2.nttmcl.com [216.69.68.200]) by mx1.FreeBSD.org (Postfix) with ESMTP id DBE4643D70 for ; Fri, 28 Apr 2006 05:29:52 +0000 (GMT) (envelope-from gene@nttmcl.com) Received: from [216.69.70.43] (bbq.nttmcl.com [216.69.70.43]) by mx2.nttmcl.com (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k3S5Tp5l018374; Thu, 27 Apr 2006 22:29:51 -0700 Message-ID: <4451A84B.90409@nttmcl.com> Date: Thu, 27 Apr 2006 22:29:47 -0700 From: "Eugene M. Kim" User-Agent: Thunderbird 1.5.0.2 (Windows/20060308) MIME-Version: 1.0 To: Scott Long References: <44518421.60408@nttmcl.com> <20060428032115.GP728@funkthat.com> <4451A140.7090100@nttmcl.com> <4451A645.6050807@samsco.org> In-Reply-To: <4451A645.6050807@samsco.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.0.3 X-Spam-Checker-Version: SpamAssassin 3.0.3 (2005-04-27) on mx2.nttmcl.com Cc: John-Mark Gurney , freebsd-stable@freebsd.org Subject: Re: link_elf: symbol cam_simq_alloc undefined X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2006 05:29:57 -0000 Oh, I see. The fix was just to make it work as a KLD, because as it stands now I can't load the module even though I don't use the CAM portion of it. Separating the amr_cam interface into a compatibility layer (like atapicam) would probably be better... I'll see if I can do it whenever I find some free time. Meanwhile, could you add the amr->cam MODULE_DEPEND line, as a temporary fix? Cheers, Eugene Scott Long wrote: > Hi, > > I broke the amr_cam interface several months ago when I locked the > driver. I've been neglecting it ever since due to lack of time, and due > to the amr_cam interface not being terribly useful. If you do in fact > have a use for it, let me know and I'll add it to my TODO list. > > Scott > > > Eugene M. Kim wrote: >> Thanks, that fixed it! : ) >> >> scottl: Could you commit (and MFC) the fix? It's as simple as adding a >> MODULE_DEPEND line: >> >> MODULE_DEPEND(amr, cam, 1, 1, 1); >> >> after the DRIVER_MODULE line in src/sys/dev/amr/amr_pci.c >> >> I'm not sure about amr_linux though; it seems that there's no CAM >> reference in amr_linux.c, but that amr_linux is just a compatibility >> layer on top of amr. In that light, perhaps: >> >> MODULE_DEPEND(amr_linux, amr, 1, 1, 1); >> >> is in order. Also, the existing MODULE_DEPEND line probably should be >> changed to: >> >> MODULE_DEPEND(amr_linux, linux, 1, 1, 1); >> >> Cheers, >> Eugene >> >> John-Mark Gurney wrote: >> >>> Eugene M. Kim wrote this message on Thu, Apr 27, 2006 at 19:55 -0700: >>> >>>> I'm trying to upgrade from 5-stable to 6-stable; after rebooting to the >>>> new kernel, the amr(4) module (amr.ko) refuses to load with this >>>> message: >>>> >>>> link_elf: symbol cam_simq_alloc undefined >>>> >>>> However, a quick nm(1) on /boot/kernel/cam.ko does show: >>>> >>>> ... >>>> 0000f0ac T cam_sim_set_path >>>> 0000efc4 T cam_simq_alloc >>>> 0000efd4 T cam_simq_free >>>> ... >>>> >>>> and cam.ko is already loaded before amr.ko. >>>> >>>> What am I missing here? *scratches head 'o 'a* >>> >>> amr is missing a: >>> MODULE_DEPEND(amr, cam, 1, 1, 1); >>> >>> which means the module doesn't get cam's symbols... might as well add >>> that line to amr_linux.c next to MODULE_DEPEND already there... >>> >> >>