From owner-freebsd-current  Thu Sep 13  0:32:10 2001
Delivered-To: freebsd-current@freebsd.org
Received: from rover.village.org (rover.bsdimp.com [204.144.255.66])
	by hub.freebsd.org (Postfix) with ESMTP id AAD5437B406
	for <current@FreeBSD.ORG>; Thu, 13 Sep 2001 00:32:06 -0700 (PDT)
Received: from harmony.village.org (harmony.village.org [10.0.0.6])
	by rover.village.org (8.11.3/8.11.3) with ESMTP id f8D7Vv616329;
	Thu, 13 Sep 2001 01:31:57 -0600 (MDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1])
	by harmony.village.org (8.11.3/8.11.4) with ESMTP id f8D7Vut96075;
	Thu, 13 Sep 2001 01:31:56 -0600 (MDT)
	(envelope-from imp@harmony.village.org)
Message-Id: <200109130731.f8D7Vut96075@harmony.village.org>
To: Julian Elischer <julian@elischer.org>
Subject: Re: KSE usage, and one forgotten item (PC98) 
Cc: current@FreeBSD.ORG, FreeBSD98-testers@jp.freebsd.org
In-reply-to: Your message of "Wed, 12 Sep 2001 23:59:21 PDT."
		<3BA05949.1CCB2D82@elischer.org> 
References: <3BA05949.1CCB2D82@elischer.org>  <200109130128.f8D1Sdt63787@harmony.village.org> <Pine.BSF.4.21.0109121737020.59165-100000@InterJet.elischer.org> <200109130314.f8D3E4t94541@harmony.village.org> 
Date: Thu, 13 Sep 2001 01:31:56 -0600
From: Warner Losh <imp@harmony.village.org>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

In message <3BA05949.1CCB2D82@elischer.org> Julian Elischer writes:
: All looks good.. obviously the logic of what was going on was easy
: enough to pick up :-)
: 
: the only bit I didn't see so easily was:
: 
:  static int
: -fdformat(dev, finfo, p)
: +fdformat(dev, finfo, td)
:         dev_t dev;
:         struct fd_formb *finfo;
: -       struct proc *p;
: +       struct thread *td;
:  {
: +       struct proc *p = td->td_proc;
:         fdu_t   fdu;
:         fd_p    fd;
:  
: @@ -2860,7 +2861,7 @@
:         /*
:          * keep the process from being swapped
:          */
: -       PHOLD(p);
: +       PROC_LOCK(p);
:         bzero((void *)bp, sizeof(*bp));
:         bp->bio_cmd = BIO_FORMAT;
:  
: @@ -2898,7 +2899,7 @@
:         /*
:          * allow the process to be swapped
:          */
: -       PRELE(p);
: +       PROC_UNLOCK(p);
:         free(bp, M_TEMP);
:         return rv;
:  }
: 
: the replacement of PHOLD with PROC_LOCK().. I'm not sure of what this actualy
: means..

Since I don't know what either PHOLD or PROC_LOCK are, I don't know if
I did this right.  Maybe it is bogus.

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message