From owner-freebsd-ports@FreeBSD.ORG Sat Nov 14 15:46:36 2009 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 59D03106566C for ; Sat, 14 Nov 2009 15:46:36 +0000 (UTC) (envelope-from freebsduser@paradisegreen.co.uk) Received: from mail.paradisegreen.co.uk (almaz.paradisegreen.co.uk [81.187.228.2]) by mx1.freebsd.org (Postfix) with ESMTP id BD5258FC0A for ; Sat, 14 Nov 2009 15:46:35 +0000 (UTC) Received: from [10.0.0.200] ([10.0.0.200]) by mail.paradisegreen.co.uk (8.13.3/8.13.3) with ESMTP id nAEFkVDI012088 for ; Sat, 14 Nov 2009 15:46:32 GMT (envelope-from freebsduser@paradisegreen.co.uk) DomainKey-Signature: a=rsa-sha1; s=default; d=paradisegreen.co.uk; c=nofws; q=dns; h=message-id:date:from:user-agent:mime-version:to:subject: references:in-reply-to:content-type:content-transfer-encoding; b=hMpg5nlgb6shPwSW0YfkoHdbzv9/BARecLSSWClpC8vp3UUhWXnGITPElyweXvkcr DpERuVENzoG0E3LbuZ4og== Message-ID: <4AFED0D3.2050403@paradisegreen.co.uk> Date: Sat, 14 Nov 2009 15:46:27 +0000 From: Thomas Sandford User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: ports@freebsd.org References: <4AF897A4.3070408@delphij.net> <20091109225232.GA34294@lor.one-eyed-alien.net> <4AF9B6CC.5090308@delphij.net> <20091113011000.GA45256@atarininja.org> <20091113200607.GA59749@atarininja.org> In-Reply-To: <20091113200607.GA59749@atarininja.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VERIFIED autolearn=failed version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on almaz.paradisegreen.co.uk Cc: Subject: Re: RFC: svn for make fetch X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Nov 2009 15:46:36 -0000 Wesley Shields wrote: > On Fri, Nov 13, 2009 at 10:00:08AM +0200, Eitan Adler wrote: >> Actually I was thinking of eventually adding non-svn support as well.... > > I don't think bloating bsd.*.mk for the most common VCS out there is a > good idea, not to mention what happens when someone wants support for > some oddball VCS that is not normally used? > >> The reason I started on this project is because the version of mplayer in >> ports is severely out of date. When I tried to update to port I noticed that >> the project wants you to compile and install from svn. I also noticed a few >> other ports that have hacks to let the maintainers "use his/her custom >> scripts" stuck into the port's Makefile. I think it would be good if there >> was some standardized way of solving both of these problems... > > Sure, but it doesn't belong in bsd.*.mk. Turn it into a script and > submit it as a regular port. If it were just one port and/or just a port maintainers tool I'd agree. But this is something that affects MULTIPLE ports. Surely the whole value/purpose of the ports build infrastructure is to present a consistent way of doing things rather than different maintainers doing their own thing and solving problems in different, and quite possibly sub-optimal ways and/or bloating multiple individual port Makefiles with what could be kept in a single bsd.*.mk file. And if the file were (say) bsd.vcs.mk and were pulled in only if one of USE_SVNFETCH USE_CVSFETCH USE_GITFETCH etc were defined then the impact of the bloat on other ports is minimal. A quick scan of ports reveals that the following contain the string "svn export" in their Makefile ports/cad/kicad-devel ports/comms/wsjt ports/comms/wspr ports/devel/compiler-rt ports/devel/llvm-devel ports/devel/thrift ports/games/evq3 ports/games/q2pro ports/games/freeorion ports/games/worldofpadman ports/net-im/cjc ports/www/twiki ports/www/foswiki ports/x11-toolkits/gigi This thread has revealed at least two further ports that use a svn distribution but where this is hidden from the user. That's 15 ports already that could be sharing common code instead of doing it themselves. How many do you need? -- Thomas Sandford