From owner-cvs-src@FreeBSD.ORG  Wed Apr 14 13:15:13 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3349216A4D0; Wed, 14 Apr 2004 13:15:13 -0700 (PDT)
Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.157.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C103F43D45; Wed, 14 Apr 2004 13:15:07 -0700 (PDT)
	(envelope-from mark@grondar.org)
Received: from storm.FreeBSD.org.uk (Ugrondar@localhost [127.0.0.1])
	i3EKF6Ae083980;	Wed, 14 Apr 2004 21:15:06 +0100 (BST)
	(envelope-from mark@grondar.org)
Received: (from Ugrondar@localhost)i3EKF69P083979;
	Wed, 14 Apr 2004 21:15:06 +0100 (BST)
	(envelope-from mark@grondar.org)
X-Authentication-Warning: storm.FreeBSD.org.uk: Ugrondar set sender to
	mark@grondar.org using -f
Received: from grondar.org (localhost [127.0.0.1])i3EKCZIn013035;
	Wed, 14 Apr 2004 21:12:35 +0100 (BST)
	(envelope-from mark@grondar.org)
From: Mark Murray <mark@grondar.org>
Message-Id: <200404142012.i3EKCZIn013035@grimreaper.grondar.org>
To: John Baldwin <jhb@FreeBSD.ORG>
In-Reply-To: Your message of "Tue, 13 Apr 2004 22:58:31 EDT."
             <200404132258.31816.jhb@FreeBSD.org> 
Date: Wed, 14 Apr 2004 21:12:34 +0100
Sender: mark@grondar.org
X-Spam-Score: 4 (****) FROM_NO_LOWER,MSGID_FROM_MTA_SHORT
X-Scanned-By: MIMEDefang 2.39
cc: cvs-src@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: Mark Murray <markm@FreeBSD.ORG>
cc: cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/dev/random randomdev.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2004 20:15:13 -0000

John Baldwin writes:
> On Monday 12 April 2004 05:13 am, Mark Murray wrote:
> > markm       2004/04/12 02:13:24 PDT
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/dev/random       randomdev.c
> >   Log:
> >   Fix "sleeping without a mutex" panic.
> 
> You should drop the lock before uiomove().  If the uio can possibly reference 
> user memory, then uiomove() will do a copyout() which can fault and thus 
> sleep if the page is in swap.

Oops. Thank you! Will do.

M
--
Mark Murray
iumop ap!sdn w,I idlaH