From owner-svn-ports-head@FreeBSD.ORG Fri Feb 21 18:49:54 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ABE167EC; Fri, 21 Feb 2014 18:49:54 +0000 (UTC) Received: from mailrelay011.isp.belgacom.be (mailrelay011.isp.belgacom.be [195.238.6.178]) by mx1.freebsd.org (Postfix) with ESMTP id C00271FDC; Fri, 21 Feb 2014 18:49:53 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlUGAOKeB1NbsI2W/2dsb2JhbABagwY7S8BJgQ4XdIIlAQEFOhwjEAsOBgQJJQ8qHgaIHAEIyzwXjjEzB4Q4BJgzgTOQdYMuOw Received: from 150.141-176-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.176.141.150]) by relay.skynet.be with ESMTP; 21 Feb 2014 19:49:51 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.8/8.14.8) with ESMTP id s1LIno5U018621; Fri, 21 Feb 2014 19:49:50 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Fri, 21 Feb 2014 19:49:49 +0100 From: Tijl Coosemans To: Baptiste Daroussin Subject: Re: svn commit: r345514 - head/Mk/Uses Message-ID: <20140221194949.29595e47@kalimero.tijl.coosemans.org> In-Reply-To: <201402211647.s1LGlTuw053335@svn.freebsd.org> References: <201402211647.s1LGlTuw053335@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Feb 2014 18:49:54 -0000 On Fri, 21 Feb 2014 16:47:29 +0000 (UTC) Baptiste Daroussin wrote: > Author: bapt > Date: Fri Feb 21 16:47:29 2014 > New Revision: 345514 > URL: http://svnweb.freebsd.org/changeset/ports/345514 > QAT: https://qat.redports.org/buildarchive/r345514/ > > Log: > libtool 1.4.2a was defining the shared extension as shrext_cmds, rename it shared_ext > like in newer libtool so the rest of USES=iconv magic just works > > Modified: > head/Mk/Uses/libtool.mk > > Modified: head/Mk/Uses/libtool.mk > ============================================================================== > --- head/Mk/Uses/libtool.mk Fri Feb 21 16:04:38 2014 (r345513) > +++ head/Mk/Uses/libtool.mk Fri Feb 21 16:47:29 2014 (r345514) > @@ -22,7 +22,8 @@ patch-libtool: > -e '/link_all_deplibs[0-9A-Z_]*=/s/=unknown/=no/' \ > -e '/objformat=/s/echo aout/echo elf/' \ > -e "/freebsd-elf\\*)/,/;;/ { \ > - /deplibs_check_method=/s/=.*/=pass_all/; }" > + /deplibs_check_method=/s/=.*/=pass_all/; }" \ > + -e "s/shrext_cmds/shared_ext/g" > > .if ! ${libtool_ARGS:Moldver} > @${FIND} ${WRKDIR} \( -name configure -or -name ltconfig \) \ Both shrext_cmds and shared_ext exist so I'm not sure it's safe to use only one name. shrext_cmds is defined by configure (normally just .so for us) or by libtool when invoked with -shrext some_extension. Then later libtool defines shared_ext using 'eval shared_ext=\"$shrext_cmds\"'. What port does this fix?