From owner-svn-src-user@FreeBSD.ORG Wed Oct 24 15:41:25 2012 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B667EE54; Wed, 24 Oct 2012 15:41:25 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id E7F7B8FC1E; Wed, 24 Oct 2012 15:41:24 +0000 (UTC) Received: by mail-vb0-f54.google.com with SMTP id v11so860471vbm.13 for ; Wed, 24 Oct 2012 08:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=TGYjDtdXWhONM3mRvqg+zjum9uRZn23u/rdjd4+4OBM=; b=xmLLMEU7cxp28HWYRs06sng54+wdOQnSlCxxNyYMWS0H9idB/z+IyhMhSabHnv6vlO l+ywHFv0UzpvTJJanAM2ckpd4RXENUYhsGkJo51YBQB/5gZr71p+b+M1eDsjQOUZNVTk rg9ORC9YpcwPxhBJYtGW8mrNevuYuCUKFMEVQImH3r7QR69WDlOZIsZ2GbdQm0AslKCc JzGyMEH2jqrsJJ1C0OfGuIcQD+P/XONE76/p50+/puQUHQU+/wstQu1OFEBRI04fHAzY M+OcbPhmy0w4X/PNtdXtDNeYwpgDI/7+FVvc0Zw7hy1VZaQpEZiztNYnjjma4cfHY+8z 5RbQ== MIME-Version: 1.0 Received: by 10.52.89.172 with SMTP id bp12mr22030964vdb.19.1351093284273; Wed, 24 Oct 2012 08:41:24 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.220.150.197 with HTTP; Wed, 24 Oct 2012 08:41:24 -0700 (PDT) In-Reply-To: <201210241136.06154.jhb@freebsd.org> References: <201210221418.q9MEINkr026751@svn.freebsd.org> <201210241136.06154.jhb@freebsd.org> Date: Wed, 24 Oct 2012 16:41:24 +0100 X-Google-Sender-Auth: 3BuSjfLVIpAZV-8ZpenyeefsdhM Message-ID: Subject: Re: svn commit: r241889 - in user/andre/tcp_workqueue/sys: arm/arm cddl/compat/opensolaris/kern cddl/contrib/opensolaris/uts/common/dtrace cddl/contrib/opensolaris/uts/common/fs/zfs ddb dev/acpica dev/... From: Attilio Rao To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: mdf@freebsd.org, src-committers@freebsd.org, Andre Oppermann , Bruce Evans , svn-src-user@freebsd.org X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2012 15:41:25 -0000 On Wed, Oct 24, 2012 at 4:36 PM, John Baldwin wrote: > On Wednesday, October 24, 2012 11:24:22 am Attilio Rao wrote: >> On Wed, Oct 24, 2012 at 4:09 PM, Attilio Rao wrote: >> > On Wed, Oct 24, 2012 at 3:45 PM, John Baldwin wrote: >> >> On Wednesday, October 24, 2012 10:34:34 am Attilio Rao wrote: >> >>> On Wed, Oct 24, 2012 at 3:05 PM, John Baldwin wrote: >> >>> > On Tuesday, October 23, 2012 7:20:04 pm Andre Oppermann wrote: >> >>> >> On 24.10.2012 00:15, mdf@FreeBSD.org wrote: >> >>> >> > On Tue, Oct 23, 2012 at 7:41 AM, Andre Oppermann >> >> wrote: >> >>> >> >> Struct mtx and MTX_SYSINIT always occur as pair next to each other. >> >>> >> > >> >>> >> > That doesn't matter. Language basics like variable definitions should >> >>> >> > not be obscured by macros. It either takes longer to figure out what >> >>> >> > a variable is (because one needs to look up the definition of the >> >>> >> > macro) or makes it almost impossible (because now e.g. cscope doesn't >> >>> >> > know this is a variable definition. >> >>> >> >> >>> >> Sigh, cscope doesn't expand macros? >> >>> >> >> >>> >> Is there a way to do the cache line alignment in a sane way without >> >>> >> littering __aligned(CACHE_LINE_SIZE) all over the place? >> >>> > >> >>> > I was hoping to do something with an anonymous union or some such like: >> >>> > >> >>> > union mtx_aligned { >> >>> > struct mtx; >> >>> > char[roundup2(sizeof(struct mtx), CACHE_LINE_SIZE)]; >> >>> > } >> >>> > >> >>> > I don't know if there is a useful way to define an 'aligned mutex' type >> >>> > that will transparently map to a 'struct mtx', e.g.: >> >>> > >> >>> > typedef struct mtx __aligned(CACHE_LINE_SIZE) aligned_mtx_t; >> >>> >> >>> Unfortunately that doesn't work as I've verified with alc@ few months ago. >> >>> The __aligned() attribute only works with structures definition, not >> >>> objects declaration. >> >> >> >> Are you saying that the typedef doesn't (I expect it doesn't), or that this >> >> doesn't: >> >> >> >> struct mtx foo __aligned(CACHE_LINE_SIZE); >> > >> > I meant to say that such notation won't address the padding issue >> > which is as import as the alignment. Infact, for sensitive locks, >> > having just an aligned object is not really useful if the cacheline >> > gets shared. >> > In the end you will need to use explicit padding or use __aligned in >> > the struct definition, which cannot be used as a general pattern. >> >> The quickest way I see this can be made general is to have a specific >> struct defined in sys/_mutex.h like that >> >> struct mtx_unshare { >> struct mtx lock; >> char _pad[CACHE_LINE_SIZE - sizeof(struct mtx)]; >> } __aligned(CACHE_LINE_SIZE); > > I think instead you want my union above that uses roundup2 in case a lock > eats up multiple cache lines: Do you think locks can eat more than one cacheline? This would be absolutely killer for performance. > union mtx_foo { > struct mtx lock; > char junk[roundup2(sizeof(struct mtx), CACHE_LINE_SIZE)]; > } __aligned_CACHE_LINE_SIZE; > >> then let mtx_* functions to accept void ptrs and cast them to struct >> mtx as long as the functions enter. > > Eh, that removes all compile time type checks. That seems very dubious to me. Well right now fast path already has a fair amount of macros wrapping the operations, which don't really enforce any type checks. Another way to do this would be to forsee an helper function to extract the struct mtx from the mtx_unshare and pass it to underlying mtx_* functions. Attilio -- Peace can only be achieved by understanding - A. Einstein