From owner-freebsd-current@FreeBSD.ORG Wed Jun 18 16:03:24 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 36FF310656D6 for ; Wed, 18 Jun 2008 16:03:24 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id B9C0C8FC26 for ; Wed, 18 Jun 2008 16:03:23 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m5IG38Hd058177; Wed, 18 Jun 2008 12:03:16 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-current@freebsd.org Date: Wed, 18 Jun 2008 11:52:46 -0400 User-Agent: KMail/1.9.7 References: <200805291209.48652.jhb@freebsd.org> <20080601131447.B0D5255BFF@mail.asahi-net.or.jp> In-Reply-To: <20080601131447.B0D5255BFF@mail.asahi-net.or.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806181152.46549.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Wed, 18 Jun 2008 12:03:17 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/7499/Wed Jun 18 09:02:05 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: WATANABE Kazuhiro Subject: Re: fe(4) MPSAFE patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jun 2008 16:03:24 -0000 On Sunday 01 June 2008 09:14:47 am WATANABE Kazuhiro wrote: > Hi. > > At Thu, 29 May 2008 12:09:48 -0400, > John Baldwin wrote: > > I have a patch to make fe(4) MPSAFE. I have no hardware to test with however. > > If you have this hardware, then test this patch. > > > > http://www.FreeBSD.org/~jhb/patches/fe.patch > > I've tested your patch with the following NICs and they works fine. > > * Ungermann-Bass Access/PC N98C+ (PC85152) (C-Bus) > > fe0 at port 0x1cd0-0x1cdf,0x1ed0-0x1edf irq 6 on isa0 > fe0: Ethernet address: 00:dd:01:xx:xx:xx > fe0: [ITHREAD] > fe0: type Access/PC > > * Allied Telesis RE2001Plus (ISA) > > fe0 at port 0x300-0x31f irq 10 on isa0 > fe0: Ethernet address: 00:00:f4:xx:xx:xx > fe0: [ITHREAD] > fe0: type AT-1700T/RE2001 > > Thanks for your work! When you get a chance, can you test http://www.FreeBSD.org/~jhb/patches/fe_wdog.patch? It handles the watchdog timer better and also changes the driver to use bus_foo() rather than bus_space_foo(). -- John Baldwin