From owner-freebsd-bugs@freebsd.org Fri Jan 8 01:26:11 2021 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AEA704E29B7 for ; Fri, 8 Jan 2021 01:26:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4DBlmg4McRz4hS5 for ; Fri, 8 Jan 2021 01:26:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 93C964E29B6; Fri, 8 Jan 2021 01:26:11 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 938C64E28CD for ; Fri, 8 Jan 2021 01:26:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DBlmg3jtGz4hKX for ; Fri, 8 Jan 2021 01:26:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7296D1B084 for ; Fri, 8 Jan 2021 01:26:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1081QBkI080161 for ; Fri, 8 Jan 2021 01:26:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1081QBwv080160 for bugs@FreeBSD.org; Fri, 8 Jan 2021 01:26:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 251906] autofs: automounter always only adds to /var/db/mounttab but never clears it Date: Fri, 08 Jan 2021 01:26:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rew@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2021 01:26:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251906 Robert Wing changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #221111|0 |1 is obsolete| | --- Comment #15 from Robert Wing --- Created attachment 221372 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D221372&action= =3Dedit create a common unmount routine for automount This patch goes back to using FSID's. The problem with my original patch us= ing FSID's was that I was calling `strlen()` on an uninitialized character array which was producing undefined results. I was able to reproduce the problem. This patch also creates a common unmount routine that will try to unmount u= sing umount(8) and if that fails will fallback to using unmount(3). Comment #14 was likely from an error when using `f_mntfromname` and should = be fixed with this patch by using the FSID instead. Comment #13 is a separate problem from this one. I was able to reproduce th= at issue as well though - I'll look into it. Thanks for the reporting and testing Martin, much appreciated! -Rob --=20 You are receiving this mail because: You are the assignee for the bug.=