Date: Fri, 08 Aug 2003 12:26:30 -0700 From: Sam Leffler <sam@errno.com> To: Jon Baldwin <jhb@FreeBSD.org> Cc: Perforce Change Reviews <perforce@FreeBSD.org> Subject: RE: PERFORCE change 35749 for review Message-ID: <157867631.1060345590@melange.errno.com> In-Reply-To: <XFMail.20030808142831.jhb@FreeBSD.org> References: <XFMail.20030808142831.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 07-Aug-2003 Sam Leffler wrote: >> http://perforce.freebsd.org/chv.cgi?CH=35749 >> >> Change 35749 by sam@sam_ebb on 2003/08/07 15:29:55 >> >> o must unlock before destroying mutex >> o must lock rt_gwroute before freeing when cleaning up on error > > It's ok to own a mutex when you destroy it. It's actually fairly > desirable in fact since it is a rather foolproof way of making sure > someone else doesn't own it. Of course, they could still be blocked on > it.. :-/ That's what I thought and was counting on, but I was getting crashes in the mutex code trying to clear the sleep list. Unlocking first fixed it (and I looked around and saw some other code doing it too--I think). I'll add it to my TODO list to look at. Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?157867631.1060345590>